-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add online and ready functions based on Spring Boot Actuator #14399
Conversation
@@ -45,7 +47,7 @@ | |||
@Configuration | |||
@PropertySource( | |||
name = "Dubbo Endpoints Default Properties", | |||
value = "classpath:/META-INF/dubbo-endpoints-default.properties") | |||
value = "classpath:/META-INF/dubbo-endpoints-default" + ".properties") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this
* | ||
* @since 3.3.0 | ||
*/ | ||
@Endpoint(id = "dubboonline") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offline is also useful
…ace,loggerInfo,Ls,switchLogger,switchLogLevel
…able) router snapshot,get enabled(recent) router snapshot
Quality Gate passedIssues Measures |
* @since 3.3.0 | ||
*/ | ||
@Component | ||
public class DubboGetEnabledRouterMetadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named for ServiceOfEnabledRouterSnapshot better, here don't have to add metadata suffix.
The same as below.
@Autowired | ||
public ApplicationModel applicationModel; | ||
|
||
public Map<String, Object> baseOffline( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operation here should depend on QoS and should not be rewritten.
What is the purpose of the change
It implements the online (to be improved) and ready functions based on Spring Boot Actuator and equivalent to the QoS functions
Brief changelog
Verifying this change
Checklist