Fix: change client error message of issue #972 #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
+ Coverage 59.59% 59.61% +0.01%
===========================================
Files 261 261
Lines 12930 12930
===========================================
+ Hits 7706 7708 +2
+ Misses 4255 4254 -1
+ Partials 969 968 -1
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Jan 4, 2021
remoting/getty/getty_client.go
Outdated
| errClientReadTimeout = perrors.New("client read timeout") | ||
| errSessionNotExist = perrors.New("session not exist") | ||
| errClientClosed = perrors.New("client closed") | ||
| errClientReadTimeoutOrDecoedFail = perrors.New("client read timeout or decode pkg fail") |
There was a problem hiding this comment.
Decoed？ may be it should be decoded?
yakecanlee
force-pushed
the
feature/fix-client-timeout-error-message
branch
from
93d7315 to
f662099
Compare
yakecanlee
force-pushed
the
feature/fix-client-timeout-error-message
branch
from
f662099 to
780a05c
Compare
AlexStocks
approved these changes
Jan 4, 2021
georgehao
approved these changes
Jan 4, 2021
|
May be errClientReadError is better, because the error.news have the details of error. |
cityiron
approved these changes
Jan 5, 2021
fangyincheng
approved these changes
Jan 5, 2021
AlexStocks
changed the title
AlexStocks
added a commit
that referenced
this pull request
Jan 5, 2021
…ror-message Fix: change client error message of issue #972
AlexStocks
added a commit
that referenced
this pull request
Jan 5, 2021
…ror-message Fix: change client error message of issue #972
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
…ror-message Fix: change client error message of issue #972
|
为什么数据解析和等待超时的错误在一起，就很无解 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
fix client error message
Which issue(s) this PR fixes:
Fixes #972
Special notes for your reviewer:
Does this PR introduce a user-facing change?: