Fix: make metadata report work without serviceDiscovery #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvictory
force-pushed
the
fix/metadata_fail
branch
from
785e323
to
5a7f093
Compare
Codecov Report
@@ Coverage Diff @@
## develop #948 +/- ##
===========================================
- Coverage 59.66% 59.53% -0.13%
===========================================
Files 261 261
Lines 12919 12952 +33
===========================================
+ Hits 7708 7711 +3
- Misses 4240 4268 +28
- Partials 971 973 +2
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Dec 22, 2020
AlexStocks
reviewed
Dec 22, 2020
AlexStocks
approved these changes
Dec 22, 2020
AlexStocks
force-pushed
the
develop
branch
6 times, most recently
from
f002d8a
to
8aba190
Compare
Patrick0308
reviewed
Dec 27, 2020
There was a problem hiding this comment.
dubbo-go/registry/servicediscovery/service_discovery_registry.go
Lines 177 to 180 in af6b6c0
We don't need publish service definition in service_discovery_registry.
common/extension/metadata_service.go
Outdated
| remoteMetadataService, err = creator() | ||
| return remoteMetadataService, err | ||
| } | ||
| logger.Info("could not find the metadata service creator for metadataType: remote") |
metadata/service/remote/service.go
Outdated
| BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{ | ||
| ServiceInterface: interfaceName, | ||
| Version: url.GetParam(constant.VERSION_KEY, ""), | ||
| // Group: url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP), |
There was a problem hiding this comment.
if not use, pls remove it
AlexStocks
force-pushed
the
develop
branch
4 times, most recently
from
546dabf
to
70eb671
Compare
AlexStocks
force-pushed
the
develop
branch
11 times, most recently
from
d12bf6a
to
e633a73
Compare
AlexStocks
force-pushed
the
develop
branch
2 times, most recently
from
603f989
to
794ab77
Compare
cityiron
reviewed
Jan 19, 2021
metadata/service/remote/service.go
Outdated
| id := &identifier.MetadataIdentifier{ | ||
| BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{ | ||
| ServiceInterface: interfaceName, | ||
| Version: url.GetParam(constant.VERSION_KEY, ""), | ||
| // Group: url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP), | ||
| Group: url.GetParam(constant.GROUP_KEY, constant.DUBBO), | ||
| Side: url.GetParam(constant.SIDE_KEY, "provider"), | ||
| Side: url.GetParam(constant.SIDE_KEY, "consumer"), |
There was a problem hiding this comment.
SIDE_KEY consumer and provider should refer from constant
Patrick0308
approved these changes
Jan 20, 2021
|
This pr is resolve issue#939? |
Patrick0308
reviewed
Jan 21, 2021
metadata/service/remote/service.go
Outdated
| url.RangeParams(func(key, value string) bool { | ||
| params[key] = value | ||
| return true | ||
| }) | ||
| id := &identifier.MetadataIdentifier{ | ||
| BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{ | ||
| ServiceInterface: interfaceName, | ||
| Version: url.GetParam(constant.VERSION_KEY, ""), | ||
| // Group: url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP), |
AlexStocks
force-pushed
the
develop
branch
2 times, most recently
from
25c3b98
to
9a666eb
Compare
watermelo
approved these changes
Jan 23, 2021
| @@ -116,22 +116,40 @@ func (mts *MetadataService) UnsubscribeURL(url *common.URL) error { | |||
| func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error { | |||
There was a problem hiding this comment.
The value of error always return nil.
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Fix: make metadata report work without serviceDiscovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The metadata should work without ServiceDiscovery. So I think should add some logic in service_config.go and reference_config.go