Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: etcd cluster reconnect #828

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Conversation

watermelo
Copy link
Member

What this PR does:
fix etcd cluster reconnect

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@watermelo watermelo added this to the v1.5.4 milestone Oct 31, 2020
@watermelo watermelo changed the title Fix: etcd reconnect Fix: etcd cluster reconnect Oct 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #828 into develop will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #828      +/-   ##
===========================================
+ Coverage    59.80%   60.04%   +0.24%     
===========================================
  Files          259      260       +1     
  Lines        12752    12770      +18     
===========================================
+ Hits          7626     7668      +42     
+ Misses        4171     4140      -31     
- Partials       955      962       +7     
Impacted Files Coverage Δ
remoting/etcdv3/facade.go 0.00% <0.00%> (ø)
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-9.33%) ⬇️
cluster/router/healthcheck/default_health_check.go 94.11% <0.00%> (-5.89%) ⬇️
remoting/kubernetes/watch.go 75.00% <0.00%> (-4.35%) ⬇️
remoting/kubernetes/client.go 72.72% <0.00%> (-3.04%) ⬇️
remoting/kubernetes/registry_controller.go 50.20% <0.00%> (-1.23%) ⬇️
protocol/dubbo/dubbo_invoker.go 75.00% <0.00%> (-1.06%) ⬇️
config/config_loader.go 53.15% <0.00%> (ø)
registry/consul/utils.go 67.50% <0.00%> (ø)
registry/nacos/registry.go 50.74% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a3656...aebb0e8. Read the comment docs.

@zouyx zouyx added the bug Something isn't working label Oct 31, 2020
@zouyx zouyx merged commit 4618a47 into apache:develop Oct 31, 2020
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Oct 31, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants