Ftr: Add dubbo-go-cli telnet tool support #818
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.5 #818 +/- ##
==========================================
+ Coverage 59.45% 59.46% +0.01%
==========================================
Files 261 261
Lines 12950 12973 +23
==========================================
+ Hits 7700 7715 +15
- Misses 4276 4282 +6
- Partials 974 976 +2
Continue to review full report at Codecov.
|
tools/cli/README.md
Outdated
| @@ -0,0 +1,18 @@ | |||
| # dubbo-go-cli | |||
|
|
|||
| ### 1. 解决问题 | |||
There was a problem hiding this comment.
hey, guy, pls using English in an Apache project. Or u rename this file to readme_cn.md and add an English readme.
tools/cli/client/client.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func createTCPAddr(host string, port int) string { |
There was a problem hiding this comment.
pls using net.JoinHostPort instead.
tools/cli/client/client.go
Outdated
| seqId := t.addPendingResponse(userPkg) | ||
| defer t.removePendingResponse(seqId) | ||
|
|
||
| requestDataChannel := make(chan []byte) |
There was a problem hiding this comment.
do not need to set its length for this chan?
tools/cli/client/client.go
Outdated
|
|
||
| requestDataChannel := make(chan []byte) | ||
| doneChannel := make(chan bool) | ||
| responseDataChannel := make(chan []byte) |
tools/cli/common/protocol.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| protocols = make(map[string]func() protocol.Protocol) |
There was a problem hiding this comment.
pls set its init length param, such as 8
tools/cli/example/README.md
Outdated
| @@ -0,0 +1,132 @@ | |||
| # dubbo-go-cli 使用示例 | |||
There was a problem hiding this comment.
the same as above readme. pls rename this file to readme_cn.md and add an english readme.
|
Now waiting for pr: apache/dubbo-go-hessian2#243 to be merged. |
|
I fix the change of hessian pkg, and problems above. Now I think it's able to merge. |
tools/cli/README.md
Outdated
|
|
||
| ### Third party dependence（temporary） | ||
|
|
||
| github.com/LaurenceLiZhixin/dubbo-go-hessian2 \ |
tools/cli/README.md
Outdated
| ### Third party dependence（temporary） | ||
|
|
||
| github.com/LaurenceLiZhixin/dubbo-go-hessian2 \ | ||
| github.com/LaurenceLiZhixin/json-interface-parser |
There was a problem hiding this comment.
pls submit ur code to github.com/dubbogo/gost.
AlexStocks
force-pushed
the
develop
branch
3 times, most recently
from
d12bf6a to
e633a73
Compare
AlexStocks
force-pushed
the
develop
branch
2 times, most recently
from
603f989 to
794ab77
Compare
AlexStocks
force-pushed
the
develop
branch
2 times, most recently
from
25c3b98 to
9a666eb
Compare
|
have u finished ur work? if so, pls fix the github action failure. |
|
I have finished my work.
|
Ftr: Add dubbo-go-cli telnet tool support
What this PR does:
增加了dubbo-go的cli命令行工具，可以方便用户直连特定服务，发送包含特定参数的rpc请求，并展现结果。
Which issue(s) this PR fixes:
Special notes for your reviewer:
支持嵌套struct，目前只支持单个参数的请求包和回包。
数据类型由于需要在json中定义，只支持golang基本数据类型：string、整形、浮点。
Does this PR introduce a user-facing change?:
NONE