Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove dingtalk temporary and fix problem in before_ut.bat #786

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Oct 9, 2020

What this PR does:

  • Remove dingtalk temporary
  • Fix problem in before_ut.bat
  • Add contribute.md into pull request template
  • Doc directory cause go get fail in github action, then delete doc directory.

https://github.com/apache/dubbo-go/pull/786/checks?sha=eb098d009e10015035cf6b1600dc4a9c977a3da1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added bug Something isn't working improve Refactor or improve labels Oct 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #786 into develop will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #786      +/-   ##
===========================================
+ Coverage    59.80%   59.91%   +0.11%     
===========================================
  Files          259      259              
  Lines        12737    12737              
===========================================
+ Hits          7617     7632      +15     
+ Misses        4166     4152      -14     
+ Partials       954      953       -1     
Impacted Files Coverage Δ
cluster/router/chain/chain.go 59.34% <0.00%> (-4.07%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (ø)
remoting/kubernetes/watch.go 79.34% <0.00%> (+2.17%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.31% <0.00%> (+2.40%) ⬆️
remoting/kubernetes/client.go 75.75% <0.00%> (+3.03%) ⬆️
...tocol/rest/server/server_impl/go_restful_server.go 51.16% <0.00%> (+4.65%) ⬆️
metadata/report/delegate/delegate_report.go 39.83% <0.00%> (+10.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c0535...f4c03f7. Read the comment docs.

@AlexStocks AlexStocks merged commit 968650f into apache:develop Oct 9, 2020
Copy link
Contributor

@williamfeng323 williamfeng323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zouyx zouyx deleted the feature/removeDingTalk branch October 31, 2020 16:24
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Fix: Remove dingtalk temporary and fix problem in before_ut.bat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants