Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exporter append #722

Merged
merged 10 commits into from
Sep 5, 2020
Merged

fix exporter append #722

merged 10 commits into from
Sep 5, 2020

Conversation

gaoxinge
Copy link

What this PR does:

1

if len(regUrls) > 0的分支里面,对regUrls进行循环,其中每个regUrl生成的exporter都应该放到appendexporters里面。但是现在的代码里面只有最后一个appendexporters里面了。

所以应该在代码的216行下面加一个c.exporters = append(c.exporters, exporter)

@zouyx zouyx added this to the 1.5.2 milestone Aug 20, 2020
@AlexStocks AlexStocks requested review from zouyx and hxmhlt and removed request for zouyx August 21, 2020 02:21
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Show resolved Hide resolved
@zouyx zouyx added the improve Refactor or improve label Aug 30, 2020
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexStocks AlexStocks merged commit 6388c4a into apache:develop Sep 5, 2020
@gaoxinge gaoxinge deleted the read branch September 9, 2020 05:35
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Sep 22, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants