Fix: Register service instance after provider config load #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Aug 13, 2020
AlexStocks
reviewed
Aug 16, 2020
| @@ -146,6 +151,20 @@ func (invoker *baseClusterInvoker) doSelectInvoker(lb cluster.LoadBalance, invoc | |||
| return selectedInvoker | |||
| } | |||
|
|
|||
| func (invoker *baseClusterInvoker) Invoke(ctx context.Context, invocation protocol.Invocation) protocol.Result { | |||
| if invoker.interceptor != nil { | |||
There was a problem hiding this comment.
if invoker.interceptor == nil {
return nil
}
invoker.interceptor.BeforeInvoker(ctx, invocation)
result := invoker.interceptor.DoInvoke(ctx, invocation)
invoker.interceptor.AfterInvoker(ctx, invocation)
return result
zouyx
reviewed
Aug 18, 2020
| logger.Warn(err) | ||
| return nil | ||
| } | ||
| list, err := metaDataService.GetExportedURLs(constant.ANY_VALUE, constant.ANY_VALUE, constant.ANY_VALUE, constant.ANY_VALUE) |
There was a problem hiding this comment.
why not define a new variable with var selectedUrl common.URL
There was a problem hiding this comment.
selectedUrl is above
| } | ||
| selectedUrl = url | ||
| // rest first | ||
| if url.Protocol == "rest" { |
There was a problem hiding this comment.
if break this loop when find rest protocol, is it a problem or bug in multi protocol ?
There was a problem hiding this comment.
dubbo in java use rest url first.
AlexStocks
changed the title
AlexStocks
changed the title
AlexStocks
reviewed
Aug 18, 2020
zouyx
approved these changes
Aug 20, 2020
AlexStocks
reviewed
Aug 20, 2020
AlexStocks
approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## 1.5.1 #694 +/- ##
==========================================
+ Coverage 63.89% 63.93% +0.03%
==========================================
Files 239 239
Lines 12752 12795 +43
==========================================
+ Hits 8148 8180 +32
- Misses 3818 3822 +4
- Partials 786 793 +7
Continue to review full report at Codecov.
|
pantianying
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Register service instance after provider config load
Which issue(s) this PR fixes:
Fixes #686