Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s ut bug #693

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Fix k8s ut bug #693

merged 2 commits into from
Aug 6, 2020

Conversation

sxllwx
Copy link
Member

@sxllwx sxllwx commented Aug 5, 2020

What this PR does:

fix kubernetes remoting pkg ut bug

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added this to the 1.5.1 milestone Aug 5, 2020
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions, as below.

  • Can you explain what problem do you fix ?
  • Will it cause a problem if won't sleep after data listener in production ?

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 269714a into apache:develop Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants