Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd: upgrade package version #672

Merged
merged 21 commits into from
Jul 26, 2020
Merged

Upd: upgrade package version #672

merged 21 commits into from
Jul 26, 2020

Conversation

gaoxinge
Copy link

@gaoxinge gaoxinge commented Jul 25, 2020

What this PR does:

  • update package version by following Raise the version of consul and client-go #656
    • github.com/hashicorp/consul to v1.8.0
    • github.com/hashicorp/consul/api to v1.5.0
    • k8s.io/api to v0.16.9
    • k8s.io/apimachinery to v0.16.9
    • k8s.io/client-go to v0.16.9
  • make etcd client codes more simple and clean
  • decrease the stack level of logger, so logger.Warnf will not show stack trace info

Which issue(s) this PR fixes:

Fixes #656.

Special notes for your reviewer:

  • NONE

Does this PR introduce a user-facing change?:

NONE

@gaoxinge gaoxinge changed the title Consul update package version Jul 25, 2020
@AlexStocks AlexStocks changed the title update package version Upd: upgrade package version Jul 25, 2020
@gaoxinge gaoxinge changed the base branch from master to develop July 26, 2020 01:27
@codecov-commenter
Copy link

Codecov Report

Merging #672 into develop will decrease coverage by 0.02%.
The diff coverage is 74.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #672      +/-   ##
===========================================
- Coverage    63.80%   63.77%   -0.03%     
===========================================
  Files          236      237       +1     
  Lines        12313    12298      -15     
===========================================
- Hits          7856     7843      -13     
- Misses        3690     3701      +11     
+ Partials       767      754      -13     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 80.00% <ø> (ø)
cluster/cluster_impl/failback_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failback_cluster_invoker.go 78.02% <ø> (-2.20%) ⬇️
cluster/cluster_impl/failfast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 71.42% <ø> (ø)
cluster/cluster_impl/failover_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failsafe_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failsafe_cluster_invoker.go 81.81% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053aab5...cb15ad0. Read the comment docs.

@fangyincheng fangyincheng merged commit 272ddd5 into apache:develop Jul 26, 2020
@gaoxinge gaoxinge deleted the consul branch July 27, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise the version of consul and client-go
5 participants