Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement GetConfigKeysByGroup #475

Merged
merged 2 commits into from
Apr 26, 2020
Merged

implement GetConfigKeysByGroup #475

merged 2 commits into from
Apr 26, 2020

Conversation

flycash
Copy link
Member

@flycash flycash commented Apr 13, 2020

What this PR does:

Implement the method GetConfigKeysByGroup because nacos client provided the batch API

@zouyx
Copy link
Member

zouyx commented Apr 13, 2020

failing bro.Ming

@flycash flycash linked an issue Apr 23, 2020 that may be closed by this pull request
Align 2.7.5: Nacos batch query API #459
Closed
fangyincheng
fangyincheng approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit c556232 into apache:feature/dubbo-2.7.5 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangyincheng fangyincheng fangyincheng approved these changes

@zouyx zouyx zouyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align 2.7.5: Nacos batch query API
3 participants
@flycash @zouyx @fangyincheng