Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: hessian2 & getty version #473

Merged
merged 4 commits into from
Apr 12, 2020
Merged

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

update hessian2 & getty version.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is failing

@codecov-io
Copy link

Codecov Report

Merging #473 into develop will decrease coverage by 0.55%.
The diff coverage is 59.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
- Coverage    67.05%   66.49%   -0.56%     
===========================================
  Files          178      184       +6     
  Lines         9369     9683     +314     
===========================================
+ Hits          6282     6439     +157     
- Misses        2471     2606     +135     
- Partials       616      638      +22     
Impacted Files Coverage Δ
common/extension/metadata_report_factory.go 0.00% <0.00%> (ø)
common/extension/service_discovery.go 0.00% <0.00%> (ø)
common/rpc_service.go 86.25% <0.00%> (-1.18%) ⬇️
config/application_config.go 41.66% <ø> (ø)
config/consumer_config.go 56.25% <ø> (ø)
config/provider_config.go 55.88% <0.00%> (-3.50%) ⬇️
config/reference_config.go 78.70% <ø> (ø)
config_center/apollo/impl.go 82.71% <0.00%> (-4.30%) ⬇️
registry/protocol/protocol.go 81.27% <0.00%> (-0.38%) ⬇️
registry/zookeeper/registry.go 46.15% <30.00%> (-8.85%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5ec56...b330db7. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 862bf03 into apache:develop Apr 12, 2020
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants