Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: delete a judgment condition #406

Merged
merged 2 commits into from
Mar 14, 2020
Merged

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #406 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
- Coverage    67.36%   67.31%   -0.06%     
===========================================
  Files          161      161              
  Lines         8340     8339       -1     
===========================================
- Hits          5618     5613       -5     
- Misses        2199     2202       +3     
- Partials       523      524       +1
Impacted Files Coverage Δ
config_center/parser/configuration_parser.go 2.15% <0%> (+0.01%) ⬆️
config_center/nacos/facade.go 64.7% <0%> (-8.83%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3030327...9279a28. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit f01d60d into apache:develop Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants