Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrg: merge 1.3 #390

Merged
merged 16 commits into from
Mar 5, 2020
Merged

Mrg: merge 1.3 #390

merged 16 commits into from
Mar 5, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

merge 1.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #390 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
- Coverage     67.1%   67.07%   -0.03%     
===========================================
  Files          157      157              
  Lines         8244     8244              
===========================================
- Hits          5532     5530       -2     
- Misses        2191     2192       +1     
- Partials       521      522       +1
Impacted Files Coverage Δ
registry/directory/directory.go 80.23% <100%> (+1.19%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️
protocol/dubbo/client.go 67.87% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989c001...c96bb8f. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 008a1f3 into apache:develop Mar 5, 2020
@fangyincheng fangyincheng deleted the devv branch March 21, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants