Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added architecture files #379

Merged
merged 9 commits into from
Mar 1, 2020
Merged

added architecture files #379

merged 9 commits into from
Mar 1, 2020

Conversation

Isaac-Zhang
Copy link
Contributor

What this PR does:
added architecture files: png & pptx

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #379 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
+ Coverage    67.01%   67.09%   +0.08%     
===========================================
  Files          157      157              
  Lines         8239     8239              
===========================================
+ Hits          5521     5528       +7     
+ Misses        2193     2187       -6     
+ Partials       525      524       -1
Impacted Files Coverage Δ
config/service_config.go 71.96% <0%> (ø) ⬆️
common/url.go 71.15% <0%> (ø) ⬆️
registry/etcdv3/listener.go 76.74% <0%> (ø) ⬆️
filter/filter_impl/generic_filter.go 67.69% <0%> (ø) ⬆️
config_center/apollo/impl.go 87.01% <0%> (ø) ⬆️
config_center/configurator/override.go 75.4% <0%> (ø) ⬆️
config_center/zookeeper/impl.go 40% <0%> (ø) ⬆️
filter/filter_impl/auth/provider_auth.go 52.94% <0%> (ø) ⬆️
registry/zookeeper/registry.go 55.44% <0%> (ø) ⬆️
config/reference_config.go 79.8% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359a429...b672da6. Read the comment docs.

@zouyx
Copy link
Member

zouyx commented Feb 29, 2020

  1. I think the first space should same to the second space.

image

  1. Should more space like provider block.

image

  1. Spacing to parent should be consistent, Config center should be aligned.

image

@AlexStocks @hxmhlt @fangyincheng

Should the pptx file move to another project, like https://github.com/dubbogo/resources ?

@Isaac-Zhang
Copy link
Contributor Author

  1. I think the first space should same to the second space.

image

  1. Should more space like provider block.

image

  1. Spacing to parent should be consistent, Config center should be aligned.

image

@AlexStocks @hxmhlt @fangyincheng

Should the pptx file move to another project, like https://github.com/dubbogo/resources ?

1&2&3 Done.

@Isaac-Zhang
Copy link
Contributor Author

removed the source file of pptx.

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove doc/ dir.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , but this line need more straight and remove doc/ dir.

image

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 08d8cb9 into apache:develop Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants