Ftr/Transfer tracing context for dubbo protocol #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #344 +/- ##
===========================================
+ Coverage 66.88% 66.89% +0.01%
===========================================
Files 123 123
Lines 7597 7613 +16
===========================================
+ Hits 5081 5093 +12
- Misses 2024 2026 +2
- Partials 492 494 +2
Continue to review full report at Codecov.
|
zouyx
reviewed
Jan 30, 2020
common/constant/key.go
Outdated
| @@ -78,6 +78,7 @@ const ( | |||
|
|
|||
| const ( | |||
| DUBBOGO_CTX_KEY = "dubbogo-ctx" | |||
| CONTEXT_KEY = "context" | |||
There was a problem hiding this comment.
what is that key use for ? it should add some comment
There was a problem hiding this comment.
It's not used, so I remove it.
AlexStocks
reviewed
Jan 31, 2020
protocol/dubbo/listener.go
Outdated
| @@ -327,6 +331,22 @@ func (h *RpcServerHandler) OnCron(session getty.Session) { | |||
| } | |||
| } | |||
|
|
|||
| // rebuild the context by attachment. | |||
There was a problem hiding this comment.
as go lint said, the func name should be the first word of its comment.
protocol/dubbo/listener.go
Outdated
| func rebuildCtx(inv *invocation.RPCInvocation) context.Context { | ||
| ctx := context.Background() | ||
|
|
||
| // actually, if user do not use any opentracing framework, it will always be error. |
There was a problem hiding this comment.
it will always be error. --> the error will always be not nil.
protocol/dubbo/listener.go
Outdated
| // actually, if user do not use any opentracing framework, it will always be error. | ||
| spanCtx, err := opentracing.GlobalTracer().Extract(opentracing.TextMap, | ||
| opentracing.TextMapCarrier(inv.Attachments())) | ||
|
|
There was a problem hiding this comment.
delete this blank line.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We can transfer the tracing context end to end now