Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: jsonrpc #327

Merged
merged 5 commits into from
Jan 18, 2020
Merged

Fix: jsonrpc #327

merged 5 commits into from
Jan 18, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@c268f8f). Click here to learn what that means.
The diff coverage is 82.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #327   +/-   ##
==========================================
  Coverage           ?   66.72%           
==========================================
  Files              ?      118           
  Lines              ?     7419           
  Branches           ?        0           
==========================================
  Hits               ?     4950           
  Misses             ?     1978           
  Partials           ?      491
Impacted Files Coverage Δ
config/config_center_config.go 71.42% <ø> (ø)
remoting/zookeeper/client.go 63.87% <ø> (ø)
protocol/jsonrpc/server.go 60% <0%> (ø)
remoting/zookeeper/listener.go 47.17% <100%> (ø)
registry/zookeeper/registry.go 55.55% <100%> (ø)
common/proxy/proxy.go 97.87% <100%> (ø)
protocol/grpc/grpc_exporter.go 100% <100%> (ø)
config/config_loader.go 58.53% <100%> (ø)
config_center/apollo/impl.go 87.01% <100%> (ø)
protocol/grpc/server.go 66.66% <66.66%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c268f8f...7c3178e. Read the comment docs.

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more http.Response you should fix

README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit ff410ac into apache:develop Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants