Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: modidfy Refer params and add licence #317

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #317 into feature/grpc will decrease coverage by 0.02%.
The diff coverage is 95.45%.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature/grpc     #317      +/-   ##
================================================
- Coverage         66.84%   66.82%   -0.03%     
================================================
  Files               118      118              
  Lines              7396     7400       +4     
================================================
+ Hits               4944     4945       +1     
- Misses             1963     1966       +3     
  Partials            489      489
Impacted Files Coverage Δ
remoting/zookeeper/listener.go 48.2% <ø> (-1.8%) ⬇️
protocol/protocolwrapper/mock_protocol_filter.go 0% <0%> (ø) ⬆️
registry/protocol/protocol.go 81.73% <100%> (ø) ⬆️
config/reference_config.go 79.61% <100%> (+0.82%) ⬆️
protocol/grpc/client.go 87.5% <100%> (+1.78%) ⬆️
protocol/dubbo/dubbo_protocol.go 91.83% <100%> (ø) ⬆️
protocol/jsonrpc/jsonrpc_protocol.go 91.83% <100%> (ø) ⬆️
protocol/grpc/grpc_protocol.go 95.23% <100%> (ø) ⬆️
registry/directory/directory.go 83.67% <100%> (-0.12%) ⬇️
...rotocol/protocolwrapper/protocol_filter_wrapper.go 51.42% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78818e8...2d6f7f3. Read the comment docs.

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format imports

@fangyincheng
Copy link
Contributor Author

please format imports

done.

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run tests locally, it works well

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hxmhlt hxmhlt merged commit 1c0e422 into apache:feature/grpc Jan 13, 2020
@fangyincheng fangyincheng deleted the feature/grpc branch March 21, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants