Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent hash load balance #261

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Conversation

imxyb
Copy link
Contributor

@imxyb imxyb commented Nov 24, 2019

Signed-off-by: imxyb xyb4638@gmail.com

What this PR does:
add consistent hash load balance
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: imxyb <xyb4638@gmail.com>
@imxyb imxyb force-pushed the consistent-hash-lb branch from b5a0468 to 7fb327e Compare November 24, 2019 11:59
@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #261 into master will decrease coverage by 0.65%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   65.78%   65.13%   -0.66%     
==========================================
  Files         105      106       +1     
  Lines        6792     6860      +68     
==========================================
  Hits         4468     4468              
- Misses       1876     1944      +68     
  Partials      448      448
Impacted Files Coverage Δ
cluster/loadbalance/consistent_hash.go 91.17% <91.17%> (ø)
cluster/cluster_impl/base_cluster_invoker.go 54.71% <0%> (-16.99%) ⬇️
protocol/dubbo/pool.go 57.86% <0%> (-15.74%) ⬇️
protocol/dubbo/listener.go 51.19% <0%> (-10.72%) ⬇️
protocol/dubbo/codec.go 76.47% <0%> (-5.89%) ⬇️
protocol/dubbo/readwriter.go 67.9% <0%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e7ed0...80e5bf5. Read the comment docs.

cluster/loadbalance/consistent_hash.go Show resolved Hide resolved
cluster/loadbalance/consistent_hash.go Outdated Show resolved Hide resolved
cluster/loadbalance/consistent_hash.go Outdated Show resolved Hide resolved
@imxyb imxyb force-pushed the consistent-hash-lb branch from 7269258 to f8470a2 Compare November 27, 2019 07:49
@imxyb imxyb force-pushed the consistent-hash-lb branch from f8470a2 to b5e4514 Compare November 28, 2019 15:07
@imxyb
Copy link
Contributor Author

imxyb commented Nov 29, 2019

@fangyincheng @zouyx @hxmhlt PTAL

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Show resolved Hide resolved
@imxyb imxyb force-pushed the consistent-hash-lb branch from b5e4514 to caece88 Compare December 11, 2019 03:53
Signed-off-by: imxyb <xyb4638@gmail.com>
@imxyb imxyb force-pushed the consistent-hash-lb branch from caece88 to 80e5bf5 Compare December 13, 2019 05:28
@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit c27f733 into apache:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants