Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:fix url params unsafe #201

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Conversation

hxmhlt
Copy link
Contributor

@hxmhlt hxmhlt commented Sep 11, 2019

What this PR does:
Fix fix url params unsafe completely.

Which issue(s) this PR fixes:

Fixes #200

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #201 into develop will increase coverage by 1.17%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
+ Coverage     66.7%   67.88%   +1.17%     
===========================================
  Files           94       94              
  Lines         5820     5847      +27     
===========================================
+ Hits          3882     3969      +87     
+ Misses        1538     1476      -62     
- Partials       400      402       +2
Impacted Files Coverage Δ
registry/consul/utils.go 68.08% <0%> (-3.03%) ⬇️
registry/nacos/registry.go 74.5% <100%> (+0.5%) ⬆️
registry/zookeeper/registry.go 62.91% <100%> (+0.31%) ⬆️
registry/etcdv3/registry.go 56.25% <100%> (+0.5%) ⬆️
...rotocol/protocolwrapper/protocol_filter_wrapper.go 51.42% <100%> (ø) ⬆️
common/url.go 75.98% <85.71%> (+1.09%) ⬆️
remoting/zookeeper/client.go 63.58% <0%> (+0.86%) ⬆️
remoting/zookeeper/listener.go 46.9% <0%> (+1.54%) ⬆️
protocol/dubbo/readwriter.go 70.37% <0%> (+2.46%) ⬆️
protocol/dubbo/codec.go 82.35% <0%> (+5.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf198d0...d6fadc1. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 92b2055 into apache:develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants