Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gettyRPCClientPool.remove deadlock #183

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

pantianying
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@AlexStocks AlexStocks changed the title Fix deadlock Fix: gettyRPCClientPool.remove deadlock Aug 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #183 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   66.48%   66.28%   -0.21%     
==========================================
  Files          90       90              
  Lines        5541     5540       -1     
==========================================
- Hits         3684     3672      -12     
- Misses       1465     1476      +11     
  Partials      392      392
Impacted Files Coverage Δ
protocol/dubbo/pool.go 59.01% <100%> (-0.23%) ⬇️
cluster/cluster_impl/base_cluster_invoker.go 54.71% <0%> (-16.99%) ⬇️
registry/etcdv3/registry.go 55.74% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d97e9...ad15595. Read the comment docs.

@AlexStocks
Copy link
Contributor

pls change the target branch from master to develop.

@pantianying pantianying changed the base branch from master to develop August 30, 2019 05:52
@AlexStocks AlexStocks requested a review from hxmhlt August 30, 2019 06:44
@AlexStocks
Copy link
Contributor

LGTM. @hxmhlt pls review and merge it.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit a8cb98e into apache:develop Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants