hessian2 supports setting the type of Java method parameters #1625
Conversation
|
merge cannot be performed at the moment. Wait until hessian2 releases the new version |
binbin0325
force-pushed
the
support_params_type
branch
from
489c85e
to
ada547d
Compare
binbin0325
changed the title
|
maybe u should add an ut for this pr. |
binbin0325
force-pushed
the
support_params_type
branch
from
ada547d
to
a01284f
Compare
done |
|
@LaurenceLiZhixin ready to merge, need to trigger the CI again |
binbin0325
force-pushed
the
support_params_type
branch
from
a01284f
to
26e3a78
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #1625 +/- ##
==========================================
- Coverage 41.16% 41.12% -0.04%
==========================================
Files 253 253
Lines 14506 14509 +3
==========================================
- Hits 5971 5967 -4
- Misses 7844 7853 +9
+ Partials 691 689 -2
Continue to review full report at Codecov.
|
| @@ -490,6 +490,10 @@ func getArgType(v interface{}) string { | |||
| } | |||
| switch t.Kind() { | |||
| case reflect.Struct: | |||
| p, ok := v.(hessian.Param) | |||
There was a problem hiding this comment.
Param name makes me confused, I think it's better if it is called inherited names and interfaces respectively.
BTW, I think inherited names and interfaces should return a string array to fit all inheritance scenarios. For instance, class A inherits from class B, and class B inherits from class C, so the return value of inherited names is []string{B, C}.
There was a problem hiding this comment.
这个看上去应该给hessian 提交个issue？ @justxuewei
| @@ -490,6 +490,10 @@ func getArgType(v interface{}) string { | |||
| } | |||
| switch t.Kind() { | |||
| case reflect.Struct: | |||
| p, ok := v.(hessian.Param) | |||
There was a problem hiding this comment.
这个看上去应该给hessian 提交个issue？ @justxuewei
What this PR does:
hessian2 supports setting the type of Java method parameters
Which issue(s) this PR fixes:
Fixes #1624
Special notes for your reviewer:
Does this PR introduce a user-facing change?: