Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nacos support UnRegister and UnSubscribe #1616

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

binbin0325
Copy link
Member

What this PR does:
nacos support UnRegister and UnSubscribe
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1616 (1a6369e) into 3.0 (fe19465) will decrease coverage by 0.06%.
The diff coverage is 35.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1616      +/-   ##
==========================================
- Coverage   40.97%   40.90%   -0.07%     
==========================================
  Files         251      251              
  Lines       14405    14422      +17     
==========================================
- Hits         5903     5900       -3     
- Misses       7820     7840      +20     
  Partials      682      682              
Impacted Files Coverage Δ
registry/nacos/registry.go 47.13% <28.00%> (-1.42%) ⬇️
registry/nacos/listener.go 77.96% <66.66%> (-2.04%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-7.95%) ⬇️
metrics/prometheus/reporter.go 28.57% <0.00%> (+1.71%) ⬆️
filter/metrics/filter.go 100.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe19465...1a6369e. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor

这个改动很不错,之后会结合优雅下线一起做下去。

@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone Dec 1, 2021
@AlexStocks AlexStocks merged commit 1bd06c1 into apache:3.0 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants