Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Config API support #1499

Merged
merged 8 commits into from
Oct 4, 2021
Merged

New Config API support #1499

merged 8 commits into from
Oct 4, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

No description provided.

Mulavar and others added 3 commits October 2, 2021 09:58
* feat(config): add root&application config api

* feat(config): add protocol config api

* feat(config): remove structure embedding

* feat(config): add registry config api builder

* feat(config): add service discovery config api builder

* feat(config): add prefix Set

* feat(config): add consumer&provider&metric&metadata&remote_route&logger config api

Co-authored-by: dongjianhui03 <dongjianhui03@meituan.com>
@LaurenceLiZhixin LaurenceLiZhixin requested review from zhaoyunxing92 and AlexStocks and removed request for zhaoyunxing92 October 2, 2021 08:13
@LaurenceLiZhixin
Copy link
Contributor Author

This pr's ci may pass after this pr merge:

apache/dubbo-go-samples#265

The config API samples is updating

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #1499 (f7ecfb6) into 3.0 (c164f38) will decrease coverage by 0.61%.
The diff coverage is 18.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1499      +/-   ##
==========================================
- Coverage   42.71%   42.10%   -0.62%     
==========================================
  Files         261      261              
  Lines       14957    15179     +222     
==========================================
+ Hits         6389     6391       +2     
- Misses       7819     8044     +225     
+ Partials      749      744       -5     
Impacted Files Coverage Δ
common/url.go 61.03% <0.00%> (ø)
config/graceful_shutdown_config.go 17.14% <0.00%> (-20.36%) ⬇️
config/reference_config.go 0.00% <0.00%> (ø)
config/remote_config.go 8.33% <0.00%> (-8.91%) ⬇️
config/router_config.go 5.26% <0.00%> (-16.17%) ⬇️
config/service_discovery_config.go 0.00% <0.00%> (-50.00%) ⬇️
metrics/prometheus/reporter.go 41.56% <ø> (ø)
registry/protocol/protocol.go 74.23% <0.00%> (ø)
config/registry_config.go 20.34% <1.81%> (-11.66%) ⬇️
config/protocol_config.go 8.33% <5.88%> (-26.56%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c164f38...f7ecfb6. Read the comment docs.

// Registry registry ids
Registry []string `yaml:"registry" json:"registry" property:"registry"`
// Registries registry ids TODO Registries?
Registries []string `yaml:"registries" json:"registries" property:"registries"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要修改这个?这个只是注册中心的ids

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDs 也要用复数吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDs 也要用复数吧?

@zhaoyunxing92 zhaoyunxing92 merged commit a32573b into 3.0 Oct 4, 2021
@LaurenceLiZhixin LaurenceLiZhixin deleted the config-api branch October 6, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants