Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the exception when tcp timeout is less than 1s for 3.0 #1362 #1380

Conversation

ChangedenCZD
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #1362

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1380 (ebc6a05) into 3.0 (f192c1e) will increase coverage by 0.21%.
The diff coverage is 45.00%.

❗ Current head ebc6a05 differs from pull request most recent head 6c3e38b. Consider uploading reports for the commit 6c3e38b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1380      +/-   ##
==========================================
+ Coverage   54.75%   54.96%   +0.21%     
==========================================
  Files         272      272              
  Lines       14753    14753              
==========================================
+ Hits         8078     8109      +31     
+ Misses       5799     5768      -31     
  Partials      876      876              
Impacted Files Coverage Δ
common/url.go 61.03% <0.00%> (-0.58%) ⬇️
remoting/zookeeper/client.go 0.00% <0.00%> (ø)
remoting/getty/config.go 20.21% <33.33%> (+1.82%) ⬆️
config/registry_config.go 86.66% <100.00%> (ø)
config/remote_config.go 72.41% <100.00%> (+4.67%) ⬆️
metadata/report/etcd/report.go 53.62% <100.00%> (ø)
registry/etcdv3/registry.go 73.84% <100.00%> (+4.28%) ⬆️
registry/nacos/service_discovery.go 70.62% <100.00%> (+0.16%) ⬆️
remoting/nacos/builder.go 80.70% <100.00%> (+2.73%) ⬆️
filter/metrics/filter.go 86.36% <0.00%> (-13.64%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f192c1e...6c3e38b. Read the comment docs.

@Mulavar
Copy link
Member

Mulavar commented Aug 19, 2021

与 1.5 分支同样问题

@ChangedenCZD ChangedenCZD changed the title Fix: fix the exception when tcp timeout is less than 1s #1362 Fix: fix the exception when tcp timeout is less than 1s for 3.0 #1362 Aug 20, 2021
remoting/getty/config.go Outdated Show resolved Hide resolved
remoting/getty/config.go Outdated Show resolved Hide resolved
@zouyx zouyx merged commit 3906343 into apache:3.0 Aug 24, 2021
@ChangedenCZD ChangedenCZD deleted the feature/fix_the_exception_when_tcp_timeout_is_less_than_1 branch September 9, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants