Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ut, replace, hash problem #1376

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1376 (77f9d6e) into 1.5 (467c867) will decrease coverage by 2.52%.
The diff coverage is 64.84%.

❗ Current head 77f9d6e differs from pull request most recent head d6ef9c0. Consider uploading reports for the commit d6ef9c0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1376      +/-   ##
==========================================
- Coverage   58.07%   55.55%   -2.53%     
==========================================
  Files         275      276       +1     
  Lines       13381    15943    +2562     
==========================================
+ Hits         7771     8857    +1086     
- Misses       4650     6150    +1500     
+ Partials      960      936      -24     
Impacted Files Coverage Δ
config/config_loader.go 43.40% <0.00%> (+4.56%) ⬆️
config/provider_config.go 62.06% <0.00%> (+7.52%) ⬆️
config/reference_config.go 80.00% <0.00%> (-1.67%) ⬇️
...gistry/event/protocol_ports_metadata_customizer.go 65.78% <ø> (+6.41%) ⬆️
registry/zookeeper/listener.go 26.58% <0.00%> (-42.65%) ⬇️
remoting/etcdv3/client.go 55.69% <0.00%> (+2.69%) ⬆️
remoting/zookeeper/listener.go 0.00% <0.00%> (-41.29%) ⬇️
config/config_center_config.go 66.21% <33.33%> (+2.03%) ⬆️
registry/directory/directory.go 77.89% <58.33%> (+2.14%) ⬆️
protocol/dubbo/dubbo_invoker.go 70.29% <60.00%> (+0.97%) ⬆️
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b670a11...d6ef9c0. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor Author

Refer to 3.0 #1267
Fix: #1349

@LaurenceLiZhixin LaurenceLiZhixin merged commit d2ddb7a into apache:1.5 Aug 13, 2021
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants