Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #135] add failback_cluster_invoker && failsafe_cluster_invoker. #136

Merged
merged 2 commits into from
Aug 3, 2019

Conversation

xujianhai666
Copy link
Member

What this PR does:
Support failback_cluster_invoker
Support failsafe_cluster_invoker

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE


@xujianhai666 xujianhai666 force-pushed the failsafe branch 2 times, most recently from 720f4c2 to 63432a2 Compare July 24, 2019 15:02
@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #136 into master will increase coverage by 0.61%.
The diff coverage is 82.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   68.29%   68.91%   +0.61%     
==========================================
  Files          71       73       +2     
  Lines        4369     4471     +102     
==========================================
+ Hits         2984     3081      +97     
+ Misses       1082     1079       -3     
- Partials      303      311       +8
Impacted Files Coverage Δ
cluster/cluster_impl/failsafe_cluster.go 100% <100%> (ø)
cluster/cluster_impl/failback_cluster.go 100% <100%> (ø)
cluster/cluster_impl/failback_cluster_invoker.go 80% <80%> (ø)
cluster/cluster_impl/failsafe_cluster_invoker.go 82.6% <82.6%> (ø)
cluster/cluster_impl/failover_cluster_invoker.go 80.95% <0%> (-3.67%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go
cluster/cluster_impl/failfast_cluster.go
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36836f4...af257b8. Read the comment docs.

@xujianhai666 xujianhai666 force-pushed the failsafe branch 5 times, most recently from 6f19ff7 to e13841b Compare July 27, 2019 13:30
protocol/mock_invoker.go Outdated Show resolved Hide resolved
protocol/mock_invoker.go Outdated Show resolved Hide resolved
cluster/cluster_impl/failback_cluster_invoker.go Outdated Show resolved Hide resolved
cluster/cluster_impl/failback_cluster_invoker.go Outdated Show resolved Hide resolved
cluster/cluster_impl/failback_cluster_invoker.go Outdated Show resolved Hide resolved
cluster/cluster_impl/failback_cluster_test.go Outdated Show resolved Hide resolved
@xujianhai666 xujianhai666 force-pushed the failsafe branch 3 times, most recently from f72bf43 to f88c400 Compare August 2, 2019 02:40
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 2ac5472 into apache:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants