Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Support Custom Registry GroupName on Nacos #1353

Conversation

ChangedenCZD
Copy link
Contributor

@ChangedenCZD ChangedenCZD commented Jul 30, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #1139

Special notes for your reviewer:

config:

providers:

image

consumers:

image

center:

image

Does this PR introduce a user-facing change?:

通过引用配置中的registry.group或registries[registry].group实现自定义服务GroupName(默认为DEFAULT_GROUP),与Java一致

@ChangedenCZD
Copy link
Contributor Author

不应复用service_discovery配置,应与Java一样使用registry.group

@ChangedenCZD ChangedenCZD reopened this Jul 30, 2021
@ChangedenCZD ChangedenCZD changed the title Ftr: 支持Nacos下自定义服务的GroupName,保持与Java一致 Ftr: Support Custom Registry GroupName on Nacos Jul 30, 2021
@LaurenceLiZhixin
Copy link
Contributor

Pls make your ut pass, tks.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #1353 (1184df2) into 3.0 (0aac960) will increase coverage by 0.08%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1353      +/-   ##
==========================================
+ Coverage   41.82%   41.91%   +0.08%     
==========================================
  Files         259      259              
  Lines       15120    15132      +12     
==========================================
+ Hits         6324     6342      +18     
+ Misses       8058     8051       -7     
- Partials      738      739       +1     
Impacted Files Coverage Δ
registry/nacos/service_discovery.go 1.07% <0.00%> (-0.02%) ⬇️
registry/service_instance.go 0.00% <ø> (ø)
registry/nacos/registry.go 43.84% <40.00%> (-0.51%) ⬇️
registry/nacos/listener.go 79.83% <100.00%> (+0.70%) ⬆️
metadata/report/delegate/delegate_report.go 34.43% <0.00%> (+7.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aac960...1184df2. Read the comment docs.

@ChangedenCZD
Copy link
Contributor Author

@LaurenceLiZhixin Done.

@zhaoyunxing92
Copy link
Contributor

zhaoyunxing92 commented Aug 11, 2021

这个pr可以先缓缓,需要考虑的地方有点多
1.我们之前是interface、group、version确定服务唯一的,如果要添加registry的group修改的地方有多
2.服务上线和下线、监听等等都要有registry的group

@AlexStocks AlexStocks merged commit 267c06e into apache:3.0 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants