Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr: Generic invocation supports generalizer.Generalizer #1307

Closed
wants to merge 17 commits into from
Closed

Ftr: Generic invocation supports generalizer.Generalizer #1307

wants to merge 17 commits into from

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Jul 7, 2021 •
edited
Loading

What this PR does:

  • Ftr: Get java name from basic types or POJOs, e.g. java.lang.String(for string)
  • Tst: Add unit tests for getting java name
  • Ftr: GenericFilter supports to convert a normal invocation to the generic format
  • Tst: Add unit tests for GenericFilter
  • Ftr: GenericServiceFilter is ready for generalizer.Generalizer
  • Tst: Add unit tests for GenericServiceFilter
  • Ftr: Add MapGeneralizer
    • Support to generalize object with a pointer
    • Support to get java name from a POJO object, and insert a new key named "class" into result
    • Support to handle nil value
    • Add unit tests to MapGeneralizer for the aforementioned features
  • Ftr: Support "protobuf-json" field in ReferenceConfig
  • //TODO: Add ProtobufJsonGeneralizer

see #1315

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@justxuewei justxuewei changed the title [WIP]Ftr: Generic filter supports "protobuf-json" serialization [WIP]Ftr: Generic invoke supports "protobuf-json" serialization Jul 7, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone Jul 7, 2021
@justxuewei
Merge branch 'refs/heads/3.0' into feat/generic-invoke
fd27487 
# Conflicts:
#	filter/generic/filter.go
#	filter/generic/service_filter.go
@justxuewei
map generalizer
c9428b6
@justxuewei
adjust import block
38c834b
@justxuewei justxuewei changed the title [WIP]Ftr: Generic invoke supports "protobuf-json" serialization [WIP]Ftr: Generic invocation supports "protobuf-json" serialization Jul 9, 2021
@justxuewei justxuewei changed the title [WIP]Ftr: Generic invocation supports "protobuf-json" serialization [WIP]Ftr: Generic invocation supports generalizer.Generalizer Jul 11, 2021
@justxuewei justxuewei changed the title [WIP]Ftr: Generic invocation supports generalizer.Generalizer Ftr: Generic invocation supports generalizer.Generalizer Jul 11, 2021
@justxuewei justxuewei mentioned this pull request Jul 11, 2021
Merged
@justxuewei justxuewei closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@justxuewei @LaurenceLiZhixin