Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance optimization: change time.After => time.NewTimer for 3.0 #1300

Merged
merged 21 commits into from
Jul 5, 2021

Conversation

mark4z
Copy link
Member

@mark4z mark4z commented Jul 5, 2021

What this PR does:
performance optimization: change time.After => time.NewTimer
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


dependabot bot and others added 21 commits April 19, 2021 05:55
Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.4...1a9e213)

Signed-off-by: dependabot[bot] <support@github.com>
…develop/actions/cache-v2.1.5

build(deps): bump actions/cache from v2.1.4 to v2.1.5
…#1260)

* make the package v3router/judger test coverage rate reach 80%

* add router_chain unit test

* refactor imports and some code

* remove blank lines

Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>
* supplementary fix apache#1254

remove unused comments

fix import cycle

append apache license header

fix gracefulShutdownFilter unittest bug

go fmt

fix gracefulShutdownConfig unittest bug

fix gracefulShutdownConfig unittest bug

go fmt

* improve formatting based on code style

* go fmt

* set RequestsFinished explicitly

* use mutex to protect variables of ShutdownConfig

* ftr: add config (apache#1258)

* recover gracefulShutdownFilter logic

* remove unused mutex

Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
* refine grpc test code

* fix test

* remove useless code

* config test grpc server
Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn>
* nacos config center optimize

* up remote config

* add protocol chick

* up:代码优化

* go fmt
@codecov-commenter
Copy link

Codecov Report

Merging #1300 (512882c) into 3.0 (e3bbd34) will increase coverage by 0.60%.
The diff coverage is 78.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1300      +/-   ##
==========================================
+ Coverage   55.58%   56.18%   +0.60%     
==========================================
  Files         272      273       +1     
  Lines       12809    12780      -29     
==========================================
+ Hits         7120     7181      +61     
+ Misses       4783     4694      -89     
+ Partials      906      905       -1     
Impacted Files Coverage Δ
...ster/router/v3router/judger/method_match_judger.go 60.71% <ø> (+60.71%) ⬆️
cluster/router/v3router/uniform_route.go 57.14% <ø> (-5.36%) ⬇️
config/uniform_router_config.go 0.00% <ø> (ø)
registry/zookeeper/registry.go 47.05% <0.00%> (ø)
filter/filter_impl/graceful_shutdown_filter.go 55.17% <20.00%> (-15.20%) ⬇️
config_center/nacos/client.go 14.28% <50.00%> (-6.47%) ⬇️
.../router/v3router/judger/attachment_match_judger.go 66.66% <61.53%> (+30.95%) ⬆️
protocol/grpc/server.go 76.27% <66.66%> (+0.40%) ⬆️
config/remote_config.go 68.00% <70.00%> (-8.48%) ⬇️
config/config_center_config.go 60.00% <83.33%> (-3.50%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893bfb5...512882c. Read the comment docs.

@AlexStocks AlexStocks merged commit 3a1b260 into apache:3.0 Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants