Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Fix ListenDirEvent #130

Merged
merged 7 commits into from
Jul 17, 2019
Merged

Feature/Fix ListenDirEvent #130

merged 7 commits into from
Jul 17, 2019

Conversation

aliiohs
Copy link
Member

@aliiohs aliiohs commented Jul 16, 2019

What this PR does:
change select time.After to wheel.After
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@aliiohs aliiohs changed the title Feature/f ix listen d ir event Feature/ix listenDirEvent Jul 16, 2019
@aliiohs aliiohs changed the title Feature/ix listenDirEvent Feature/Fix ListenDirEvent Jul 16, 2019
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #130 into master will decrease coverage by 0.73%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   68.01%   67.28%   -0.74%     
==========================================
  Files          69       69              
  Lines        4346     4346              
==========================================
- Hits         2956     2924      -32     
- Misses       1085     1120      +35     
+ Partials      305      302       -3
Impacted Files Coverage Δ
remoting/zookeeper/listener.go 45.94% <0%> (-2.71%) ⬇️
remoting/zookeeper/facade.go 74.28% <100%> (ø) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 48.93% <0%> (-19.15%) ⬇️
protocol/dubbo/pool.go 56.98% <0%> (-5.03%) ⬇️
config_center/zookeeper/listener.go 82.6% <0%> (-4.35%) ⬇️
protocol/dubbo/listener.go 53.66% <0%> (-2.76%) ⬇️
remoting/zookeeper/client.go 63.76% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197f248...56a873a. Read the comment docs.

@AlexStocks AlexStocks merged commit 7cf9e2c into apache:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants