Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster interceptor support #1206

Merged
merged 6 commits into from
May 20, 2021
Merged

Conversation

beiwei30
Copy link
Member

What this PR does:

Refactor ClusterInterceptor to chain mode, and allow to load user defined cluster interceptors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@gaoxinge
Copy link

Add apache license in new files:

  • common/extension/cluster_interceptor.go
  • cluster/cluster_impl/zone_aware_cluster_interceptor.go
  • cluster/cluster_impl/interceptor_invoker.go

to pass license check in ci.

@beiwei30
Copy link
Member Author

Add apache license in new files:

  • common/extension/cluster_interceptor.go
  • cluster/cluster_impl/zone_aware_cluster_interceptor.go
  • cluster/cluster_impl/interceptor_invoker.go

to pass license check in ci.

sure, will do after I verify the solution.

@codecov-commenter
Copy link

Codecov Report

Merging #1206 (776a31f) into 1.5 (a10ff4d) will decrease coverage by 7.57%.
The diff coverage is 60.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1206      +/-   ##
==========================================
- Coverage   66.13%   58.56%   -7.58%     
==========================================
  Files         174      271      +97     
  Lines        9343    13224    +3881     
==========================================
+ Hits         6179     7744    +1565     
- Misses       2541     4519    +1978     
- Partials      623      961     +338     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 384 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf877e...776a31f. Read the comment docs.

@AlexStocks AlexStocks merged commit 5a9a038 into apache:1.5 May 20, 2021
@beiwei30 beiwei30 deleted the cluster-interceptor branch May 20, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants