Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:nacos service provider does not require subscribe #1056

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

kzhan
Copy link
Contributor

@kzhan kzhan commented Feb 16, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #1056 (e6dd108) into develop (5c76040) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1056      +/-   ##
===========================================
- Coverage    59.51%   59.39%   -0.12%     
===========================================
  Files          261      261              
  Lines        12960    12963       +3     
===========================================
- Hits          7713     7700      -13     
- Misses        4272     4290      +18     
+ Partials       975      973       -2     
Impacted Files Coverage Δ
registry/nacos/registry.go 49.28% <0.00%> (-1.08%) ⬇️
remoting/kubernetes/registry_controller.go 46.12% <0.00%> (-5.31%) ⬇️
remoting/kubernetes/watch.go 76.92% <0.00%> (-2.20%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 75.90% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c76040...e6dd108. Read the comment docs.

@zouyx zouyx added the improve Refactor or improve label Feb 19, 2021
@AlexStocks AlexStocks merged commit 5db3ebf into apache:develop Feb 23, 2021
@cityiron cityiron added this to the v1.5.7 milestone Feb 24, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
fix:nacos service provider does not require subscribe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants