Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Add an "api way" to set general configure #1020

Merged
merged 13 commits into from
Feb 25, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:
This pr add an "API way" to set general configure.
Usage can be found at my branch:
https://github.com/LaurenceLiZhixin/dubbo-go-samples/blob/ftr/samples-add/config-api/go-client/cmd/client.go
or in test file

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #1020 (8354e91) into develop (c8fb3e9) will increase coverage by 0.20%.
The diff coverage is 68.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1020      +/-   ##
===========================================
+ Coverage    59.54%   59.74%   +0.20%     
===========================================
  Files          261      262       +1     
  Lines        12957    13152     +195     
===========================================
+ Hits          7715     7858     +143     
- Misses        4266     4316      +50     
- Partials       976      978       +2     
Impacted Files Coverage Δ
common/extension/metadata_service.go 0.00% <0.00%> (ø)
filter/filter_impl/sentinel_filter.go 63.04% <ø> (ø)
metadata/service/remote/service.go 32.95% <0.00%> (ø)
...try/servicediscovery/service_discovery_registry.go 11.56% <ø> (-0.21%) ⬇️
config_center/file/impl.go 50.42% <42.85%> (+0.02%) ⬆️
registry/nacos/registry.go 50.36% <57.14%> (-0.77%) ⬇️
config/config_api.go 74.25% <74.25%> (ø)
registry/etcdv3/registry.go 64.15% <75.00%> (-0.77%) ⬇️
...rotocol/protocolwrapper/protocol_filter_wrapper.go 50.00% <100.00%> (ø)
registry/etcdv3/listener.go 67.50% <100.00%> (+1.71%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a721a2...8354e91. Read the comment docs.

config/config_api.go Outdated Show resolved Hide resolved
config/config_api.go Show resolved Hide resolved
@AlexStocks AlexStocks changed the title Ftr/configAPI: Add an "api way" to set general configue. Ftr: Add an "api way" to set general configure Jan 27, 2021
}
}

///////////////////////////////////////// Application config api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// enough

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base on security, I am not agree with modify configuration by web API .

@AlexStocks
Copy link
Contributor

pls change the target branch to 1.5

@LaurenceLiZhixin LaurenceLiZhixin changed the base branch from develop to 1.5 February 2, 2021 09:55
@gaoxinge
Copy link

gaoxinge commented Feb 5, 2021

This pull request may correspond to the dubbo java's api configuration. I think this is a nice configuration feature for people who start to use dubbo-go. @AlexStocks @zouyx

@zouyx
Copy link
Member

zouyx commented Feb 8, 2021

This pull request may correspond to the dubbo java's api configuration. I think this is a nice configuration feature for people who start to use dubbo-go. @AlexStocks @zouyx

I will agree,if not web API .

@zouyx zouyx added the improve Refactor or improve label Feb 8, 2021
@AlexStocks
Copy link
Contributor

very good pr. however, u should add comment for every func.

@AlexStocks AlexStocks merged commit 96e3f2b into apache:1.5 Feb 25, 2021
@cityiron cityiron added this to the v1.5.7 milestone Feb 25, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Ftr:  Add an "api way" to set general configure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants