Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router from CONF_ROUTER_FILE_PATH doesn't take affect. #1151

Closed
beiwei30 opened this issue Apr 12, 2021 · 0 comments
Closed

router from CONF_ROUTER_FILE_PATH doesn't take affect. #1151

beiwei30 opened this issue Apr 12, 2021 · 0 comments

Comments

@beiwei30
Copy link
Member

What happened:

If router comes from CONF_ROUTER_FILE_PATH, it will not be built into router chain at all.

		case remoting.EventTypeAdd, remoting.EventTypeUpdate:
			logger.Infof("selector add service url{%s}", event.Service)
			if u != nil && constant.ROUTER_PROTOCOL == u.Protocol {
				dir.configRouters()
			}
			return dir.cacheInvoker(u), nil

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
@beiwei30 beiwei30 mentioned this issue Apr 13, 2021
Closed
@beiwei30 beiwei30 mentioned this issue Apr 26, 2021
Merged
AlexStocks added a commit that referenced this issue May 15, 2021
@beiwei30 @AlexStocks
fix: issue #1151 - router from CONF_ROUTER_FILE_PATH doesn't take aff…
3df419d 
…ect (#1176)

* fix: issue #1151 - router from CONF_ROUTER_FILE_PATH doesn't take affect

* reformat the code

Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexStocks @beiwei30