Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](Nereids) not release lock if schema changed when insert #47733 #47761

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

morrySnow
Copy link
Contributor

pick from master #47733

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 11, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40533 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f6982554159eb133edf3705891548c9ad9ea27d, data reload: false

------ Round 1 ----------------------------------
q1	17771	7351	7226	7226
q2	2073	171	171	171
q3	10540	1060	1143	1060
q4	10578	740	730	730
q5	7740	2914	2878	2878
q6	237	146	144	144
q7	992	612	611	611
q8	9360	1894	2060	1894
q9	6776	6433	6374	6374
q10	7052	2330	2280	2280
q11	475	265	266	265
q12	398	209	209	209
q13	17790	2966	2983	2966
q14	236	204	202	202
q15	564	527	506	506
q16	685	582	588	582
q17	971	515	562	515
q18	7207	6500	6665	6500
q19	1397	1114	1085	1085
q20	481	204	196	196
q21	3972	3151	3242	3151
q22	1103	988	1023	988
Total cold run time: 108398 ms
Total hot run time: 40533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7219	7219	7142	7142
q2	327	234	231	231
q3	2873	2943	2944	2943
q4	2026	1810	1860	1810
q5	5725	5720	5701	5701
q6	226	148	141	141
q7	2244	1787	1831	1787
q8	3345	3506	3563	3506
q9	8740	8918	8854	8854
q10	3585	3544	3590	3544
q11	596	522	505	505
q12	792	576	588	576
q13	10171	3195	3154	3154
q14	300	266	269	266
q15	577	544	531	531
q16	706	634	655	634
q17	1839	1644	1591	1591
q18	8152	7874	7732	7732
q19	1637	1627	1550	1550
q20	2044	1884	1889	1884
q21	5509	5397	5319	5319
q22	1103	1079	1060	1060
Total cold run time: 69736 ms
Total hot run time: 60461 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198106 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f6982554159eb133edf3705891548c9ad9ea27d, data reload: false

query1	1316	914	926	914
query2	6240	2023	1947	1947
query3	10837	4138	4172	4138
query4	61192	29138	23708	23708
query5	5249	465	455	455
query6	418	182	185	182
query7	5490	321	326	321
query8	311	241	226	226
query9	8554	2691	2688	2688
query10	477	265	248	248
query11	18028	15234	15849	15234
query12	159	105	109	105
query13	1425	443	429	429
query14	9795	7299	7468	7299
query15	200	178	174	174
query16	7147	492	457	457
query17	1187	565	569	565
query18	1918	317	299	299
query19	210	156	156	156
query20	115	106	103	103
query21	206	106	107	106
query22	4813	4583	4633	4583
query23	34671	34363	34349	34349
query24	6133	2935	2953	2935
query25	514	407	384	384
query26	662	167	169	167
query27	1790	363	364	363
query28	4263	2450	2454	2450
query29	703	466	464	464
query30	262	165	165	165
query31	1009	859	836	836
query32	66	55	57	55
query33	423	296	284	284
query34	938	502	525	502
query35	854	724	730	724
query36	1091	992	987	987
query37	124	80	76	76
query38	4055	3967	3931	3931
query39	1502	1459	1474	1459
query40	212	109	101	101
query41	55	50	50	50
query42	115	103	102	102
query43	530	493	490	490
query44	1222	828	835	828
query45	196	179	169	169
query46	1163	743	737	737
query47	2044	1923	1975	1923
query48	491	417	413	413
query49	749	402	408	402
query50	868	417	418	417
query51	7363	7236	7175	7175
query52	108	90	91	90
query53	258	180	185	180
query54	588	498	479	479
query55	79	80	75	75
query56	257	238	251	238
query57	1275	1196	1121	1121
query58	218	203	203	203
query59	3112	2953	2928	2928
query60	276	256	249	249
query61	105	128	164	128
query62	822	715	736	715
query63	212	185	184	184
query64	1374	658	628	628
query65	3244	3208	3172	3172
query66	707	303	301	301
query67	15922	15499	15745	15499
query68	4260	568	566	566
query69	423	261	260	260
query70	1193	1139	1044	1044
query71	358	254	249	249
query72	6377	3972	4057	3972
query73	763	348	352	348
query74	10222	9203	9077	9077
query75	3361	2654	2664	2654
query76	1993	1000	1165	1000
query77	475	275	261	261
query78	10606	9621	9681	9621
query79	1126	583	587	583
query80	803	435	454	435
query81	514	235	227	227
query82	384	121	121	121
query83	156	139	144	139
query84	285	80	80	80
query85	831	291	284	284
query86	346	298	298	298
query87	4375	4287	4302	4287
query88	3907	2371	2353	2353
query89	408	290	294	290
query90	2035	181	187	181
query91	171	148	148	148
query92	68	51	51	51
query93	1375	544	540	540
query94	742	299	283	283
query95	349	256	258	256
query96	615	283	276	276
query97	3316	3167	3155	3155
query98	207	209	198	198
query99	1674	1404	1455	1404
Total cold run time: 311630 ms
Total hot run time: 198106 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f6982554159eb133edf3705891548c9ad9ea27d, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.53	0.49	0.49
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.58	0.50	0.51
query10	0.55	0.55	0.56
query11	0.14	0.10	0.10
query12	0.15	0.11	0.10
query13	0.61	0.60	0.58
query14	2.73	2.76	2.86
query15	0.89	0.83	0.84
query16	0.36	0.38	0.38
query17	1.04	1.06	1.02
query18	0.24	0.23	0.22
query19	1.90	1.83	1.98
query20	0.01	0.02	0.01
query21	15.36	0.61	0.57
query22	2.48	2.68	1.62
query23	17.12	0.89	0.84
query24	2.84	0.65	1.48
query25	0.25	0.19	0.10
query26	0.38	0.13	0.13
query27	0.04	0.05	0.05
query28	10.63	1.12	1.07
query29	12.61	3.23	3.23
query30	0.25	0.05	0.06
query31	2.86	0.39	0.38
query32	3.23	0.45	0.45
query33	3.01	3.04	3.06
query34	16.84	4.50	4.49
query35	4.59	4.53	4.50
query36	0.69	0.49	0.50
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 106.53 s
Total hot run time: 32.34 s

@dataroaring dataroaring merged commit 24c98c5 into branch-3.0 Feb 11, 2025
25 of 28 checks passed
@morrySnow morrySnow deleted the fix_lock branch February 11, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants