Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](function)Support Function Time #47320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

koarz
Copy link
Contributor

@koarz koarz commented Jan 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Jan 22, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 41.55% (10833/26073)
Line Coverage: 31.96% (91575/286556)
Region Coverage: 31.08% (46890/150854)
Branch Coverage: 27.17% (23748/87390)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5b5ddc7ada27d54fc44b5d2df0846aff0eaaec64_5b5ddc7ada27d54fc44b5d2df0846aff0eaaec64/report/index.html

morrySnow
morrySnow previously approved these changes Jan 22, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 22, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@koarz
Copy link
Contributor Author

koarz commented Jan 22, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 22, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32932 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 286181679fce614a056f48a5d5f6f601c5379110, data reload: false

------ Round 1 ----------------------------------
q1	17631	5496	5441	5441
q2	2051	309	174	174
q3	10428	1231	756	756
q4	10618	985	526	526
q5	8751	2410	2189	2189
q6	197	166	135	135
q7	924	772	638	638
q8	9254	1385	1219	1219
q9	5537	5057	5050	5050
q10	6880	2353	1917	1917
q11	487	288	262	262
q12	351	368	222	222
q13	17886	3758	3126	3126
q14	236	244	216	216
q15	518	462	476	462
q16	645	625	582	582
q17	589	884	335	335
q18	7101	6420	6712	6420
q19	2234	985	573	573
q20	314	341	201	201
q21	3169	2397	2154	2154
q22	386	355	334	334
Total cold run time: 106187 ms
Total hot run time: 32932 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5592	5496	6041	5496
q2	246	337	254	254
q3	2400	2904	2439	2439
q4	1493	1850	1391	1391
q5	4352	4759	4958	4759
q6	180	168	131	131
q7	2053	1972	1877	1877
q8	2654	2880	2728	2728
q9	7354	7326	7256	7256
q10	3047	3184	2699	2699
q11	587	522	501	501
q12	684	754	577	577
q13	3538	3994	3287	3287
q14	283	294	292	292
q15	509	455	467	455
q16	645	692	645	645
q17	1241	1725	1254	1254
q18	7804	7413	7234	7234
q19	861	1057	1162	1057
q20	2027	2045	1903	1903
q21	5729	5156	5048	5048
q22	599	597	570	570
Total cold run time: 53878 ms
Total hot run time: 51853 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194540 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 286181679fce614a056f48a5d5f6f601c5379110, data reload: false

query1	1320	964	934	934
query2	6438	2003	1994	1994
query3	11103	4759	4743	4743
query4	32267	23292	23225	23225
query5	3616	645	465	465
query6	279	209	204	204
query7	3980	518	317	317
query8	301	256	231	231
query9	9351	2691	2684	2684
query10	471	323	260	260
query11	17652	15253	14976	14976
query12	165	113	100	100
query13	1549	527	392	392
query14	9783	6490	7542	6490
query15	262	210	197	197
query16	7825	716	474	474
query17	1571	773	572	572
query18	2060	432	347	347
query19	231	201	177	177
query20	121	121	131	121
query21	219	137	108	108
query22	4705	4461	4288	4288
query23	34304	33679	33352	33352
query24	6759	2310	2348	2310
query25	470	489	389	389
query26	923	291	160	160
query27	2142	507	331	331
query28	5282	2500	2470	2470
query29	576	599	439	439
query30	215	203	160	160
query31	1002	951	791	791
query32	73	64	60	60
query33	480	381	346	346
query34	767	965	535	535
query35	854	865	752	752
query36	1064	1106	962	962
query37	132	111	76	76
query38	4328	4401	4291	4291
query39	1503	1446	1454	1446
query40	219	120	110	110
query41	53	52	51	51
query42	123	103	100	100
query43	525	544	507	507
query44	1384	819	833	819
query45	196	183	171	171
query46	975	1147	689	689
query47	1955	1941	1858	1858
query48	406	418	337	337
query49	770	547	461	461
query50	723	730	411	411
query51	6944	7014	7001	7001
query52	104	99	98	98
query53	240	260	186	186
query54	498	521	415	415
query55	88	85	82	82
query56	257	285	280	280
query57	1293	1244	1127	1127
query58	256	244	272	244
query59	3166	3141	3101	3101
query60	302	283	275	275
query61	114	120	117	117
query62	832	752	699	699
query63	237	191	198	191
query64	3033	1057	652	652
query65	3462	3181	3135	3135
query66	921	426	306	306
query67	16095	15694	15351	15351
query68	6207	839	538	538
query69	503	296	268	268
query70	1179	1184	1113	1113
query71	384	312	270	270
query72	5963	4039	3970	3970
query73	658	801	369	369
query74	9979	9259	8707	8707
query75	3376	3276	2694	2694
query76	3177	1328	832	832
query77	458	376	287	287
query78	10194	10418	9298	9298
query79	2385	854	605	605
query80	621	549	446	446
query81	496	287	237	237
query82	469	169	124	124
query83	175	171	153	153
query84	235	93	83	83
query85	756	347	307	307
query86	404	340	299	299
query87	4685	4499	4516	4499
query88	4911	2215	2182	2182
query89	431	350	303	303
query90	1800	192	193	192
query91	136	140	114	114
query92	66	58	55	55
query93	1814	905	549	549
query94	680	427	310	310
query95	341	272	259	259
query96	508	680	291	291
query97	2913	2899	2776	2776
query98	230	201	196	196
query99	1343	1451	1271	1271
Total cold run time: 288791 ms
Total hot run time: 194540 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 41.56% (10837/26076)
Line Coverage: 31.97% (91619/286611)
Region Coverage: 31.10% (46918/150879)
Branch Coverage: 27.19% (23758/87392)
Coverage Report: http://coverage.selectdb-in.cc/coverage/286181679fce614a056f48a5d5f6f601c5379110_286181679fce614a056f48a5d5f6f601c5379110/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 286181679fce614a056f48a5d5f6f601c5379110, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.43	0.43	0.40
query6	1.16	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.50	0.50
query10	0.55	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.62	0.61	0.59
query14	2.71	2.76	2.71
query15	0.92	0.82	0.82
query16	0.37	0.36	0.39
query17	1.09	1.10	1.07
query18	0.22	0.20	0.21
query19	1.94	1.75	1.99
query20	0.02	0.01	0.01
query21	15.36	0.90	0.60
query22	0.74	0.82	0.70
query23	15.20	1.44	0.53
query24	2.53	1.58	0.92
query25	0.33	0.09	0.12
query26	0.31	0.14	0.13
query27	0.08	0.06	0.04
query28	13.61	1.08	0.43
query29	12.56	3.92	3.26
query30	0.25	0.09	0.07
query31	2.81	0.59	0.39
query32	3.22	0.55	0.45
query33	2.98	3.03	3.13
query34	16.65	5.18	4.52
query35	4.62	4.61	4.52
query36	0.67	0.50	0.48
query37	0.09	0.07	0.07
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.32 s
Total hot run time: 30.56 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants