Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug](move-memtable) add debug logs for skip_two_backends injection cases #46826

Merged
merged 1 commit into from
Jan 12, 2025
Merged

[debug](move-memtable) add debug logs for skip_two_backends injection cases #46826

merged 1 commit into from
Jan 12, 2025
+10 −0

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Jan 11, 2025 •
edited by liaoxin01
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32558 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8098130cd3e4e15177215d7d8df7038588c0be91, data reload: false

------ Round 1 ----------------------------------
q1	17575	6509	6109	6109
q2	2074	316	173	173
q3	10561	1216	732	732
q4	10314	863	438	438
q5	8330	2187	1959	1959
q6	202	179	145	145
q7	885	738	626	626
q8	9246	1340	1161	1161
q9	5106	4849	4931	4849
q10	6797	2285	1836	1836
q11	496	283	254	254
q12	338	356	214	214
q13	17758	3653	3074	3074
q14	246	226	220	220
q15	573	518	492	492
q16	627	628	590	590
q17	547	837	323	323
q18	7102	6516	6401	6401
q19	2401	944	534	534
q20	306	307	187	187
q21	2739	2173	1937	1937
q22	357	330	304	304
Total cold run time: 104580 ms
Total hot run time: 32558 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6362	6225	6263	6225
q2	244	339	241	241
q3	2221	2653	2316	2316
q4	1425	1785	1333	1333
q5	4293	4700	4826	4700
q6	185	177	139	139
q7	2066	1949	1780	1780
q8	2628	2816	2692	2692
q9	7295	7222	7340	7222
q10	3094	3275	2804	2804
q11	603	522	504	504
q12	655	770	651	651
q13	3436	3798	3288	3288
q14	282	304	276	276
q15	556	513	500	500
q16	657	691	640	640
q17	1223	1746	1281	1281
q18	7737	7448	7575	7448
q19	768	1160	1050	1050
q20	1956	2096	1984	1984
q21	5775	5207	4952	4952
q22	615	631	583	583
Total cold run time: 54076 ms
Total hot run time: 52609 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 39.35% (10255/26059)
Line Coverage: 30.51% (87384/286415)
Region Coverage: 29.55% (44528/150689)
Branch Coverage: 26.10% (22793/87328)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8098130cd3e4e15177215d7d8df7038588c0be91_8098130cd3e4e15177215d7d8df7038588c0be91/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 194029 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8098130cd3e4e15177215d7d8df7038588c0be91, data reload: false

query1	1302	964	962	962
query2	6305	2307	2335	2307
query3	11114	4806	4884	4806
query4	32784	23361	23372	23361
query5	4106	593	429	429
query6	300	192	169	169
query7	3981	477	304	304
query8	296	231	230	230
query9	9459	2665	2656	2656
query10	477	319	251	251
query11	17850	15217	15217	15217
query12	160	107	103	103
query13	1568	511	394	394
query14	11011	6431	6624	6431
query15	261	205	189	189
query16	8117	662	455	455
query17	1615	753	615	615
query18	2156	432	320	320
query19	205	185	161	161
query20	174	123	117	117
query21	206	125	105	105
query22	4528	4603	4362	4362
query23	33952	33607	33110	33110
query24	6409	2272	2286	2272
query25	484	454	421	421
query26	787	271	148	148
query27	2549	448	334	334
query28	5830	2453	2416	2416
query29	693	563	432	432
query30	213	189	157	157
query31	937	874	815	815
query32	91	58	57	57
query33	476	354	309	309
query34	751	835	504	504
query35	790	819	751	751
query36	1032	1047	956	956
query37	123	99	78	78
query38	4041	4340	4152	4152
query39	1552	1439	1459	1439
query40	199	108	96	96
query41	51	47	49	47
query42	116	109	103	103
query43	504	525	491	491
query44	1316	821	823	821
query45	189	180	178	178
query46	876	1027	642	642
query47	1917	1877	1887	1877
query48	396	396	302	302
query49	721	500	389	389
query50	655	671	389	389
query51	6974	7153	7020	7020
query52	110	102	96	96
query53	220	250	177	177
query54	504	498	408	408
query55	78	78	81	78
query56	276	263	248	248
query57	1214	1239	1167	1167
query58	247	228	225	225
query59	3152	3213	3156	3156
query60	290	262	275	262
query61	119	115	117	115
query62	879	793	732	732
query63	221	195	192	192
query64	3630	1031	665	665
query65	3311	3304	3183	3183
query66	1048	474	302	302
query67	16208	15741	15488	15488
query68	9187	693	517	517
query69	480	283	241	241
query70	1237	1120	1129	1120
query71	436	289	284	284
query72	6450	3812	3812	3812
query73	645	740	350	350
query74	9983	8816	8720	8720
query75	3821	3135	2636	2636
query76	3640	1150	753	753
query77	773	367	261	261
query78	10123	9979	9295	9295
query79	3207	790	592	592
query80	578	516	437	437
query81	463	269	232	232
query82	632	155	123	123
query83	169	171	149	149
query84	242	87	77	77
query85	770	423	304	304
query86	347	307	255	255
query87	4479	4544	4254	4254
query88	4496	2139	2127	2127
query89	418	325	282	282
query90	1842	190	185	185
query91	135	132	106	106
query92	66	54	51	51
query93	1711	848	531	531
query94	642	399	299	299
query95	341	319	253	253
query96	477	606	276	276
query97	2883	2937	2758	2758
query98	230	201	199	199
query99	1646	1514	1406	1406
Total cold run time: 296655 ms
Total hot run time: 194029 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.94 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8098130cd3e4e15177215d7d8df7038588c0be91, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.11	0.10
query5	0.41	0.42	0.41
query6	1.15	0.65	0.66
query7	0.03	0.02	0.01
query8	0.03	0.03	0.03
query9	0.60	0.50	0.50
query10	0.56	0.56	0.56
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.72	2.83	2.84
query15	0.90	0.83	0.83
query16	0.38	0.39	0.38
query17	1.08	1.04	1.02
query18	0.24	0.21	0.22
query19	2.01	1.96	1.88
query20	0.01	0.02	0.01
query21	15.37	0.95	0.55
query22	0.77	1.01	0.68
query23	15.03	1.44	0.52
query24	3.16	1.38	1.45
query25	0.14	0.22	0.09
query26	0.21	0.14	0.13
query27	0.10	0.06	0.05
query28	14.46	1.51	1.05
query29	12.61	3.92	3.34
query30	0.26	0.09	0.07
query31	2.83	0.59	0.38
query32	3.24	0.56	0.47
query33	3.15	3.12	3.06
query34	16.49	5.12	4.53
query35	4.52	4.55	4.51
query36	0.64	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.13	0.12
query41	0.07	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.02	0.02
Total cold run time: 106.49 s
Total hot run time: 31.94 s

dataroaring
dataroaring approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 95b5b00 into apache:master Jan 12, 2025
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 12, 2025
@kaijchen
[debug](move-memtable) add debug logs for skip_two_backends injection…
1847aab 
… cases (#46826)
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @kaijchen
branch-3.0: [debug](move-memtable) add debug logs for skip_two_backen…
92ef733 
…ds injection cases #46826 (#46849)

Cherry-picked from #46826

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@kaijchen
[debug](move-memtable) add debug logs for skip_two_backends injection…
31a9bf5 
… cases (#46826)
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaijchen @Thearas @doris-robot @liaoxin01 @dataroaring @shuke987