Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](nereids) optimize push limit to agg #44042

Merged
merged 5 commits into from
Nov 27, 2024
Merged

[opt](nereids) optimize push limit to agg #44042

merged 5 commits into from
Nov 27, 2024

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

Pr #34853 introduced PushTopnToAgg rule.
But there is a limitation that Topn(limit) should output all group by keys.
This pr removes this limitation by using the first group by key as order key.

Issue Number: close #xxx

Related PR: #34853

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

run buildall

@englefly englefly marked this pull request as ready for review November 18, 2024 07:47
@englefly
Copy link
Contributor Author

run buildall

@englefly
Copy link
Contributor Author

run buildall

@englefly
Copy link
Contributor Author

run buildall

@englefly
Copy link
Contributor Author

run cloud_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit 6d57e38 into apache:master Nov 27, 2024
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
@englefly
[opt](nereids) optimize push limit to agg (#44042)
2c484f6 
### What problem does this PR solve?
Pr #34853 introduced PushTopnToAgg rule.
But there is a limitation that Topn(limit) should output all group by
keys.
This pr removes this limitation by using the first group by key as order
key.
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
morrySnow pushed a commit that referenced this pull request Nov 27, 2024
@github-actions @englefly
branch-3.0: [opt](nereids) optimize push limit to agg #44042 (#44656)
39afe63 
Cherry-picked from #44042

Co-authored-by: minghong <zhouminghong@selectdb.com>
@englefly englefly deleted the opt-push-limit-agg branch November 30, 2024 04:51
@englefly englefly mentioned this pull request Dec 12, 2024
Merged
16 tasks
englefly added a commit that referenced this pull request Dec 18, 2024
@englefly
[fix](Nereids) set correct sort key for aggregate (#45369)
a886463 
### What problem does this PR solve?
in previous #44042, we supported more patterns for PushTopnToAgg rule.
the new pattern：
topn
  +-->agg(global)
      +-->shuffle
          +-->agg(local)

In order to support this new pattern, the group by keys and orderkeys
are identical, but group keys can be in different order.
that is 
topn(orderkey=[B,A])->agg(groupkey=[A,B,C])
=>
topn(orderkey=[B, A, C]) ->agg(groupKey=[A, B, C])
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@englefly @doris-robot @starocean999 @LiBinfeng-01 @morrySnow