Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix] (bloom filter) Fix the bloom filter calculation for date and datetime #43612

Merged
merged 1 commit into from
Nov 12, 2024
Merged

branch-3.0: [fix] (bloom filter) Fix the bloom filter calculation for date and datetime #43612

merged 1 commit into from
Nov 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #43351

@csun5285
[fix] (bloom filter) Fix the bloom filter calculation for date and da…
b53571b 
…tetime (#43351)

### What problem does this PR solve?
Problem Summary:
After adding a bloom filter to the date type, queries return errors
following the upgrade.

Co-authored-by: csun5285 <sunchenyang@selectdb.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

run buildall

airborne12
airborne12 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 closed this Nov 12, 2024
@airborne12 airborne12 reopened this Nov 12, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 60f17d8 into branch-3.0 Nov 12, 2024
22 of 25 checks passed
@airborne12 airborne12 deleted the auto-pick-43351-branch-3.0 branch November 12, 2024 01:15
github-actions[bot]
github-actions bot commented Nov 12, 2024
View reviewed changes
Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/date_bloom_filter_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doris-robot @airborne12 @csun5285