Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat](cloud) S3 storage vault support property use_path_style (#43060) #43343

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

SWJTU-ZhangLei
Copy link
Contributor

example

  CREATE STORAGE VAULT IF NOT EXISTS demo_vault
    PROPERTIES (
      "type"="S3",
      ...
      "use_path_style" = "true"
  );

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…che#43060)

example 
```
  CREATE STORAGE VAULT IF NOT EXISTS demo_vault
    PROPERTIES (
      "type"="S3",
      ...
      "use_path_style" = "true"
  );
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@SWJTU-ZhangLei
Copy link
Contributor Author

pick #43060

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40349 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8313cdba3837f4432963f67629b924828c2d9901, data reload: false

------ Round 1 ----------------------------------
q1	17862	7478	7312	7312
q2	2059	159	152	152
q3	10924	1060	1147	1060
q4	10555	773	753	753
q5	7734	2894	2837	2837
q6	233	143	144	143
q7	970	602	599	599
q8	9339	1914	1956	1914
q9	6584	6417	6384	6384
q10	6957	2305	2336	2305
q11	458	274	269	269
q12	416	219	204	204
q13	17783	2957	2967	2957
q14	244	211	216	211
q15	552	507	512	507
q16	645	609	601	601
q17	985	538	612	538
q18	7277	6483	6647	6483
q19	2575	1039	1030	1030
q20	457	192	208	192
q21	3861	3157	2942	2942
q22	1067	956	969	956
Total cold run time: 109537 ms
Total hot run time: 40349 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7385	7233	7214	7214
q2	322	228	226	226
q3	2875	2875	2891	2875
q4	1994	1821	1772	1772
q5	5738	5703	5777	5703
q6	221	147	139	139
q7	2187	1791	1745	1745
q8	3316	3542	3451	3451
q9	8943	8838	8822	8822
q10	3566	3556	3531	3531
q11	594	493	506	493
q12	795	615	635	615
q13	16609	3184	3194	3184
q14	300	261	264	261
q15	566	527	508	508
q16	736	689	653	653
q17	1854	1629	1600	1600
q18	8241	7772	7372	7372
q19	1726	1497	1596	1497
q20	2054	1846	1836	1836
q21	5316	5352	5472	5352
q22	1090	1055	1021	1021
Total cold run time: 76428 ms
Total hot run time: 59870 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192829 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8313cdba3837f4432963f67629b924828c2d9901, data reload: false

query1	1222	912	932	912
query2	6264	2095	2056	2056
query3	10796	3968	3845	3845
query4	67760	29403	23314	23314
query5	5578	444	428	428
query6	471	165	165	165
query7	6187	305	297	297
query8	350	240	234	234
query9	9633	2648	2641	2641
query10	523	255	252	252
query11	18208	15280	15606	15280
query12	160	110	115	110
query13	1595	415	394	394
query14	10536	7266	6456	6456
query15	217	181	171	171
query16	7227	474	477	474
query17	1063	549	553	549
query18	1679	311	297	297
query19	197	159	158	158
query20	117	107	106	106
query21	204	100	104	100
query22	4442	4416	4202	4202
query23	34205	33624	33801	33624
query24	5719	2769	2798	2769
query25	515	416	410	410
query26	687	159	173	159
query27	1719	287	291	287
query28	4094	2522	2495	2495
query29	664	431	432	431
query30	237	151	150	150
query31	976	758	816	758
query32	63	54	52	52
query33	445	264	270	264
query34	880	500	499	499
query35	808	721	687	687
query36	1062	924	944	924
query37	121	72	71	71
query38	3866	3817	3801	3801
query39	1460	1398	1423	1398
query40	209	96	99	96
query41	50	51	49	49
query42	108	96	95	95
query43	523	471	489	471
query44	1115	760	769	760
query45	181	170	168	168
query46	1107	710	725	710
query47	1889	1829	1819	1819
query48	458	364	370	364
query49	741	392	392	392
query50	816	402	393	393
query51	7244	7106	7159	7106
query52	98	91	85	85
query53	249	185	179	179
query54	529	435	446	435
query55	74	75	73	73
query56	244	227	231	227
query57	1182	1084	1114	1084
query58	198	201	204	201
query59	3182	2966	3029	2966
query60	287	239	250	239
query61	103	106	98	98
query62	786	654	662	654
query63	210	179	182	179
query64	1704	606	610	606
query65	3222	3121	3183	3121
query66	718	309	292	292
query67	15590	15276	15440	15276
query68	4539	538	527	527
query69	418	242	244	242
query70	1141	1119	1120	1119
query71	419	245	260	245
query72	6398	3921	3819	3819
query73	762	337	336	336
query74	10034	8837	8810	8810
query75	3320	2644	2589	2589
query76	2175	948	957	948
query77	533	264	273	264
query78	10718	9706	9407	9407
query79	8682	574	579	574
query80	1931	400	415	400
query81	555	239	233	233
query82	1425	113	117	113
query83	260	134	131	131
query84	282	80	75	75
query85	1879	293	269	269
query86	486	285	258	258
query87	4430	4213	4201	4201
query88	5482	2361	2402	2361
query89	550	284	292	284
query90	2106	176	175	175
query91	175	141	164	141
query92	63	48	52	48
query93	6740	543	541	541
query94	881	291	268	268
query95	344	243	246	243
query96	637	275	276	275
query97	3365	3125	3122	3122
query98	218	198	192	192
query99	1600	1335	1261	1261
Total cold run time: 337315 ms
Total hot run time: 192829 ms

@gavinchou gavinchou merged commit 16a83fb into apache:branch-3.0 Nov 8, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants