branch-3.0: [fix](auditlog) add missing audit log fields and duplicate audit log error #43129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…error (#42262) ### What problem does this PR solve? Problem Summary: #### Issue 1 There are some fields that is missing in audit log table. This PR add them all: - shuffle_send_rows - shuffle_send_bytes - scan_bytes_from_local_storage - scan_bytes_from_remote_storage - is_nereids - compute_group Notice that `compute_group` is previously name `cloudClusterName` in fe.audit.log, which is incorrect, so I change it to the right name. After this PR, all these fields will be saved in both audit log table and fe.audit.log #### Issue 2 The `AuditEventBuilder` need to be reset at each run, the there will be duplicate audit log. #### Issue 3 Add a new statement `call flush_audit_log()`. It will flush the audit log immediately to audit_log table. This is useful in test case, so that we don't need to wait 1min to flush the audit log data. ### Release note [fix](auditlog) add missing audit log fields and duplicate audit log error
|
run buildall |
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 40192 ms |
TPC-DS: Total hot run time: 192854 ms |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 40331 ms |
TPC-DS: Total hot run time: 192828 ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Body: ### What problem does this PR solve?
Problem Summary:
Issue 1
There are some fields that is missing in audit log table.
This PR add them all:
Notice that
compute_groupis previously namecloudClusterNamein fe.audit.log,which is incorrect, so I change it to the right name.
After this PR, all these fields will be saved in both audit log table and fe.audit.log
Issue 2
The
AuditEventBuilderneed to be reset at each run, the there will be duplicate audit log.Issue 3
Add a new statement
call flush_audit_log(). It will flush the audit log immediately to audit_log table.This is useful in test case, so that we don't need to wait 1min to flush the audit log data.
Check List (For Committer)
Test
Behavior changed:
cloudClusterNamein fe.audit.log change tocomputeGroup. And some fields are added to the audit log table.Does this need documentation?
Release note
fix add missing audit log fields and duplicate audit log error
Check List (For Reviewer who merge this PR)
Cherry-picked from [fix](auditlog) add missing audit log fields and duplicate audit log error #42262