Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compile) Enable compile checking for function_json #42329

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[fix](compile) Enable compile checking for function_json #42329

merged 1 commit into from
Oct 24, 2024

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41352 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fb6fa606510d2dfa35d6f6744541d1cbd207f7e0, data reload: false

------ Round 1 ----------------------------------
q1	17575	7593	7370	7370
q2	2061	152	165	152
q3	10568	1148	1172	1148
q4	10320	873	814	814
q5	7770	3127	3090	3090
q6	243	159	152	152
q7	1002	604	600	600
q8	9346	1988	1978	1978
q9	6617	6475	6430	6430
q10	7120	2445	2411	2411
q11	449	247	252	247
q12	408	219	219	219
q13	17779	3027	3008	3008
q14	243	223	217	217
q15	571	528	514	514
q16	645	590	599	590
q17	1033	593	524	524
q18	7350	6731	6812	6731
q19	1350	969	1048	969
q20	490	186	181	181
q21	4090	3169	3020	3020
q22	1109	987	1009	987
Total cold run time: 108139 ms
Total hot run time: 41352 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7276	7253	7298	7253
q2	329	236	236	236
q3	2945	2790	2810	2790
q4	1944	1745	1735	1735
q5	5498	5518	5554	5518
q6	236	145	144	144
q7	2178	1716	1723	1716
q8	3282	3431	3443	3431
q9	8581	8602	8638	8602
q10	3517	3462	3444	3444
q11	587	482	488	482
q12	807	565	619	565
q13	9689	3021	2993	2993
q14	297	266	264	264
q15	571	510	517	510
q16	662	635	640	635
q17	1845	1580	1571	1571
q18	7870	7341	7530	7341
q19	1699	1667	1504	1504
q20	2074	1800	1808	1800
q21	5290	5177	5231	5177
q22	1100	1028	1030	1028
Total cold run time: 68277 ms
Total hot run time: 58739 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.48% (9709/25902)
Line Coverage: 28.73% (80504/280194)
Region Coverage: 28.16% (41636/147832)
Branch Coverage: 24.72% (21150/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fb6fa606510d2dfa35d6f6744541d1cbd207f7e0_fb6fa606510d2dfa35d6f6744541d1cbd207f7e0/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191411 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fb6fa606510d2dfa35d6f6744541d1cbd207f7e0, data reload: false

query1	974	372	384	372
query2	6528	2119	2062	2062
query3	6788	216	227	216
query4	34203	23718	23505	23505
query5	4287	478	467	467
query6	263	173	161	161
query7	4617	298	290	290
query8	293	238	242	238
query9	9644	2672	2658	2658
query10	475	277	273	273
query11	18052	15190	15246	15190
query12	158	104	104	104
query13	1660	430	403	403
query14	10494	7517	7349	7349
query15	303	180	165	165
query16	8081	438	476	438
query17	1737	571	582	571
query18	2150	299	311	299
query19	377	159	151	151
query20	121	107	109	107
query21	216	102	105	102
query22	4498	4222	4390	4222
query23	35242	34124	34158	34124
query24	10952	2807	2820	2807
query25	666	398	411	398
query26	1180	161	159	159
query27	2815	285	289	285
query28	7851	2419	2417	2417
query29	876	433	427	427
query30	322	161	156	156
query31	1052	808	852	808
query32	107	55	63	55
query33	776	308	292	292
query34	964	513	545	513
query35	916	744	756	744
query36	1102	937	957	937
query37	166	92	88	88
query38	3991	3878	3916	3878
query39	1496	1437	1404	1404
query40	214	102	99	99
query41	50	48	48	48
query42	118	102	97	97
query43	542	494	489	489
query44	1290	823	806	806
query45	197	165	164	164
query46	1164	688	715	688
query47	2012	1830	1874	1830
query48	418	326	317	317
query49	1160	434	432	432
query50	821	388	395	388
query51	7181	6902	6970	6902
query52	97	90	88	88
query53	256	183	179	179
query54	1333	431	435	431
query55	91	83	78	78
query56	292	262	271	262
query57	1323	1166	1167	1166
query58	256	248	259	248
query59	3207	2895	3016	2895
query60	292	267	268	267
query61	103	100	100	100
query62	871	703	672	672
query63	217	183	179	179
query64	5294	633	595	595
query65	3316	3281	3208	3208
query66	1441	313	303	303
query67	15884	15585	15556	15556
query68	4873	567	546	546
query69	489	285	288	285
query70	1204	1124	1030	1030
query71	359	271	276	271
query72	7148	4019	4000	4000
query73	782	354	365	354
query74	9919	9083	8909	8909
query75	3375	2661	2716	2661
query76	2999	940	911	911
query77	479	312	298	298
query78	10535	9591	9570	9570
query79	1753	591	616	591
query80	1097	454	440	440
query81	575	243	241	241
query82	980	140	137	137
query83	241	143	143	143
query84	254	73	75	73
query85	1279	288	281	281
query86	390	304	297	297
query87	4533	4375	4333	4333
query88	2973	2221	2172	2172
query89	396	294	284	284
query90	1979	185	187	185
query91	152	105	100	100
query92	64	49	50	49
query93	1268	546	535	535
query94	1071	290	290	290
query95	373	249	240	240
query96	612	279	285	279
query97	3291	3209	3097	3097
query98	211	196	196	196
query99	1742	1368	1291	1291
Total cold run time: 303229 ms
Total hot run time: 191411 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.25 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fb6fa606510d2dfa35d6f6744541d1cbd207f7e0, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.02	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.54	0.52	0.51
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.51
query10	0.56	0.57	0.56
query11	0.14	0.12	0.10
query12	0.13	0.14	0.11
query13	0.61	0.60	0.60
query14	2.71	2.82	2.74
query15	0.91	0.84	0.83
query16	0.40	0.39	0.38
query17	1.10	1.08	1.07
query18	0.24	0.22	0.22
query19	1.94	1.89	2.03
query20	0.01	0.01	0.01
query21	15.36	0.59	0.55
query22	2.83	1.72	1.64
query23	17.02	0.91	0.79
query24	3.64	1.75	0.53
query25	0.21	0.29	0.11
query26	0.37	0.14	0.13
query27	0.04	0.04	0.04
query28	10.31	1.10	1.09
query29	12.62	3.25	3.26
query30	0.24	0.06	0.06
query31	2.86	0.37	0.38
query32	3.28	0.46	0.48
query33	2.97	3.03	3.04
query34	17.20	4.44	4.40
query35	4.53	4.52	4.57
query36	0.67	0.48	0.49
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.65 s
Total hot run time: 32.25 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 977404e into apache:master Oct 24, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@Mryange Mryange Mryange approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @BiteTheDDDDt @Mryange