Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](inverted index) return OK instead of not supported in expr evaluate_inverted_index #41567

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[Enhancement](inverted index) return OK instead of not supported in expr evaluate_inverted_index #41567

merged 1 commit into from
Oct 9, 2024

Conversation

airborne12
Copy link
Member

Proposed changes

Fix annoying error stack info

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41001 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0d781fdc5780ba55f5234242db2de8dc917963f4, data reload: false

------ Round 1 ----------------------------------
q1	17777	8234	7336	7336
q2	2450	171	150	150
q3	10897	1142	1190	1142
q4	10238	792	746	746
q5	7733	2868	2869	2868
q6	237	149	149	149
q7	997	657	649	649
q8	9359	1935	2037	1935
q9	6547	6404	6413	6404
q10	6999	2284	2302	2284
q11	439	241	247	241
q12	419	217	227	217
q13	17780	2974	3027	2974
q14	247	210	213	210
q15	574	518	521	518
q16	634	616	582	582
q17	1009	626	558	558
q18	7261	6729	6669	6669
q19	1363	936	1047	936
q20	478	204	200	200
q21	4149	3257	3232	3232
q22	1077	1001	1046	1001
Total cold run time: 108664 ms
Total hot run time: 41001 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7241	7220	7258	7220
q2	329	230	228	228
q3	2940	2792	2821	2792
q4	1981	1722	1746	1722
q5	5480	5469	5489	5469
q6	223	140	141	140
q7	2149	1691	1747	1691
q8	3223	3411	3465	3411
q9	8548	8518	8526	8518
q10	3493	3479	3418	3418
q11	588	490	466	466
q12	784	573	600	573
q13	6952	3016	3010	3010
q14	287	256	254	254
q15	556	515	509	509
q16	673	642	648	642
q17	1808	1561	1559	1559
q18	7668	7479	7423	7423
q19	1672	1589	1511	1511
q20	2070	1807	1806	1806
q21	5566	5233	5138	5138
q22	1082	1004	995	995
Total cold run time: 65313 ms
Total hot run time: 58495 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191665 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0d781fdc5780ba55f5234242db2de8dc917963f4, data reload: false

query1	1006	378	380	378
query2	6524	2174	2142	2142
query3	6695	223	226	223
query4	33936	23546	23398	23398
query5	4374	457	452	452
query6	261	166	156	156
query7	4629	310	311	310
query8	283	224	229	224
query9	9678	2665	2688	2665
query10	495	293	299	293
query11	17904	15067	15300	15067
query12	161	100	101	100
query13	1672	464	438	438
query14	10520	7236	7518	7236
query15	295	186	182	182
query16	7829	485	453	453
query17	1732	575	576	575
query18	1560	314	331	314
query19	363	150	149	149
query20	118	106	106	106
query21	215	105	102	102
query22	4472	4346	4355	4346
query23	34812	34110	34136	34110
query24	11056	2849	2854	2849
query25	635	419	413	413
query26	1080	165	169	165
query27	2317	291	301	291
query28	7615	2422	2414	2414
query29	762	436	441	436
query30	326	155	160	155
query31	1034	790	831	790
query32	104	58	59	58
query33	793	308	314	308
query34	944	512	527	512
query35	903	740	716	716
query36	1083	970	929	929
query37	151	91	86	86
query38	4036	3843	3980	3843
query39	1509	1447	1416	1416
query40	223	97	97	97
query41	49	47	48	47
query42	112	99	96	96
query43	526	492	488	488
query44	1250	821	825	821
query45	198	167	173	167
query46	1143	732	706	706
query47	1928	1828	1844	1828
query48	453	369	341	341
query49	1137	437	405	405
query50	804	417	412	412
query51	7065	7025	6970	6970
query52	101	88	89	88
query53	267	192	188	188
query54	1337	477	482	477
query55	84	78	86	78
query56	289	262	272	262
query57	1270	1164	1157	1157
query58	274	248	280	248
query59	3179	3006	2981	2981
query60	288	274	280	274
query61	106	119	102	102
query62	867	679	652	652
query63	224	187	194	187
query64	5312	638	634	634
query65	3288	3192	3180	3180
query66	1155	308	311	308
query67	15977	15543	15421	15421
query68	4961	580	563	563
query69	454	295	293	293
query70	1203	1058	1126	1058
query71	338	266	276	266
query72	6360	3912	3851	3851
query73	763	342	349	342
query74	10121	9015	8934	8934
query75	3390	2667	2633	2633
query76	3079	901	912	901
query77	464	301	299	299
query78	10498	9557	9516	9516
query79	2317	599	622	599
query80	1244	454	446	446
query81	582	240	245	240
query82	985	134	136	134
query83	220	141	139	139
query84	251	80	77	77
query85	1320	308	278	278
query86	426	304	285	285
query87	4537	4338	4337	4337
query88	3766	2408	2372	2372
query89	400	287	289	287
query90	2046	190	192	190
query91	147	118	113	113
query92	67	52	53	52
query93	1641	551	556	551
query94	1085	300	292	292
query95	356	256	251	251
query96	619	274	282	274
query97	3312	3181	3217	3181
query98	227	201	210	201
query99	1662	1295	1295	1295
Total cold run time: 301629 ms
Total hot run time: 191665 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0d781fdc5780ba55f5234242db2de8dc917963f4, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.02
query3	0.23	0.06	0.07
query4	1.65	0.11	0.10
query5	0.50	0.50	0.53
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.03	0.03	0.03
query9	0.58	0.50	0.49
query10	0.55	0.57	0.53
query11	0.12	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.73	2.72	2.78
query15	0.90	0.83	0.84
query16	0.36	0.39	0.38
query17	0.97	1.06	1.07
query18	0.23	0.22	0.22
query19	1.98	1.88	1.95
query20	0.01	0.00	0.01
query21	15.35	0.61	0.58
query22	2.48	2.49	2.35
query23	17.15	1.00	0.77
query24	2.72	0.79	0.77
query25	0.19	0.12	0.08
query26	0.44	0.13	0.14
query27	0.04	0.03	0.04
query28	11.10	1.12	1.07
query29	12.56	3.23	3.21
query30	0.24	0.05	0.06
query31	2.86	0.38	0.37
query32	3.28	0.46	0.47
query33	2.96	3.04	3.05
query34	17.12	4.49	4.48
query35	4.50	4.46	4.52
query36	0.65	0.48	0.50
query37	0.09	0.06	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.96 s
Total hot run time: 33.02 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9628/25834)
Line Coverage: 28.67% (79871/278583)
Region Coverage: 28.10% (41288/146931)
Branch Coverage: 24.72% (21035/85086)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0d781fdc5780ba55f5234242db2de8dc917963f4_0d781fdc5780ba55f5234242db2de8dc917963f4/report/index.html

xiaokang
xiaokang reviewed Oct 9, 2024
View reviewed changes
be/src/vec/exprs/vexpr.h
@@ -120,7 +120,7 @@ class VExpr {

// execute current expr with inverted index to filter block. Given a roaring bitmap of match rows
virtual Status evaluate_inverted_index(VExprContext* context, uint32_t segment_num_rows) {
return Status::NotSupported("Not supported execute_with_inverted_index");
return Status::OK();
Copy link
Contributor

@xiaokang xiaokang Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment for semantics of just returning OK()

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 4cfd57e into apache:master Oct 9, 2024
26 of 31 checks passed
@airborne12 airborne12 deleted the enhance branch October 9, 2024 03:16
@airborne12 airborne12 mentioned this pull request Oct 9, 2024
Merged
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 9, 2024
@airborne12
[Enhancement](inverted index) return OK instead of not supported in e…
7f11b25 
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
@airborne12 airborne12 mentioned this pull request Oct 9, 2024
Merged
airborne12 added a commit that referenced this pull request Oct 9, 2024
@airborne12
[Enhancement](inverted index) return OK instead of not supported in e…
31b506c 
…xpr evaluate_inverted_index #41567 (#41578)

cherry pick from #41567
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 9, 2024
@airborne12
[Enhancement](inverted index) return OK instead of not supported in e…
908d6cc 
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
airborne12 added a commit that referenced this pull request Oct 9, 2024
@airborne12
[Enhancement](inverted index) return OK instead of not supported in e…
2dda72d 
…xpr evaluate_inverted_index #41567 (#41577)

cherry pick from #41567
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@airborne12 @eldenmoon
[Enhancement](inverted index) return OK instead of not supported in e…
62645e8 
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@airborne12 @cjj2010
[Enhancement](inverted index) return OK instead of not supported in e…
4b06fe7 
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@airborne12 @amorynan
[Enhancement](inverted index) return OK instead of not supported in e…
4543376 
…xpr evaluate_inverted_index (apache#41567)

## Proposed changes

Fix annoying error stack info
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang left review comments

@qidaye qidaye qidaye approved these changes

@csun5285 csun5285 csun5285 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@airborne12 @doris-robot @xiaokang @qidaye @csun5285