Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1](function) Refine crypto functions signature to fix wrong result(#40285) #40648

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

zclllyybb
Copy link
Contributor

pick #40285

…apache#40285)

## Proposed changes

Issue Number: close #xxx

1. remove all `aes/sm4_{encrypt/decrypt}_v2` functions signatures.
2. before for 2 args, always use `XXX_128_ECB`, now fixed it. we will
use `block_encryption_mode` when 2/3 args are given.
2.1. before this, we wrongly used `AES_128_ECB` for SM4_ENCRYPT
4. for `AES_ENCRYPT` with 2 args, we wrongly use `'AES_128_ECB'` as its
default initial string. now fixed it.

docs: apache/doris-website#1083
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

@yiguolei yiguolei merged commit 3246baa into apache:branch-2.1 Sep 11, 2024
20 of 22 checks passed
@zclllyybb zclllyybb deleted the pick_crypto_21 branch September 14, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants