Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](restore) Persist the sqlMode field of the View #40612

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 10, 2024

During initialization, the View will parse inlineViewRef again according to the sqlMode value. Therefore, sqlMode must be persisted.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Sep 10, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ee1e939 into apache:master Sep 11, 2024
26 of 29 checks passed
@w41ter w41ter deleted the persist_sql_mode branch September 11, 2024 03:05
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
During initialization, the View will parse inlineViewRef again according
to the sqlMode value. Therefore, sqlMode must be persisted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants