Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](function) fix error return type in mod(float32,BigInt) #39358

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[fix](function) fix error return type in mod(float32,BigInt) #39358

merged 2 commits into from
Aug 22, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Aug 14, 2024

Proposed changes

CREATE TABLE testdb (
    K1 BIGINT,
    K2 FLOAT
) properties("replication_num" = "1");
insert into testdb values(1,1.1);
select mod(k1,k2) from testdb;
mysql [test10]>select mod(k1,k2) from testdb;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Function mod get failed, expr is VectorizedFnCall[mod](arguments=K1, K2,return=Nullable(Float32)) and return type is Nullable(Float32).

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Aug 14, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 14, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 38291 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7f0eaf9e150108bbfe67959a4af1bee2dc02788, data reload: false

------ Round 1 ----------------------------------
q1	17620	4489	4388	4388
q2	2024	177	172	172
q3	10501	1187	1070	1070
q4	10132	696	714	696
q5	8063	2892	2857	2857
q6	235	147	145	145
q7	996	630	616	616
q8	9682	2090	2080	2080
q9	7139	6575	6579	6575
q10	7028	2173	2230	2173
q11	523	250	247	247
q12	414	228	229	228
q13	18754	2991	2992	2991
q14	282	255	237	237
q15	530	485	495	485
q16	505	397	393	393
q17	999	731	769	731
q18	7408	6790	6791	6790
q19	6822	1049	1096	1049
q20	675	337	362	337
q21	4272	3023	3062	3023
q22	1116	1009	1008	1008
Total cold run time: 115720 ms
Total hot run time: 38291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4529	4345	4295	4295
q2	376	280	270	270
q3	2871	2688	2663	2663
q4	1922	1661	1618	1618
q5	5380	5404	5427	5404
q6	224	135	135	135
q7	2051	1686	1712	1686
q8	3204	3707	3337	3337
q9	8442	8495	8426	8426
q10	3376	3167	3164	3164
q11	588	524	502	502
q12	801	617	603	603
q13	17514	2968	2963	2963
q14	287	281	265	265
q15	523	482	478	478
q16	484	419	418	418
q17	1797	1497	1487	1487
q18	7692	7609	7465	7465
q19	1673	1533	1528	1528
q20	2046	1812	1800	1800
q21	9476	5179	5115	5115
q22	1119	1016	1019	1016
Total cold run time: 76375 ms
Total hot run time: 54638 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185112 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7f0eaf9e150108bbfe67959a4af1bee2dc02788, data reload: false

query1	904	377	366	366
query2	6436	2029	1968	1968
query3	6645	204	206	204
query4	31388	23298	23026	23026
query5	4225	494	494	494
query6	294	168	158	158
query7	4597	300	299	299
query8	249	204	204	204
query9	8704	2448	2416	2416
query10	448	259	260	259
query11	17717	14978	14891	14891
query12	156	104	100	100
query13	1635	384	361	361
query14	9527	7152	7620	7152
query15	231	168	165	165
query16	7166	510	482	482
query17	1585	557	552	552
query18	1179	291	286	286
query19	193	147	149	147
query20	116	107	106	106
query21	211	108	103	103
query22	4207	4120	3994	3994
query23	33895	33119	33523	33119
query24	11623	2897	2906	2897
query25	667	396	390	390
query26	1258	158	158	158
query27	2492	281	277	277
query28	7137	2054	2035	2035
query29	896	426	420	420
query30	321	149	154	149
query31	980	745	740	740
query32	97	58	63	58
query33	761	292	297	292
query34	906	450	463	450
query35	847	718	712	712
query36	1116	921	919	919
query37	147	84	83	83
query38	3960	3848	3860	3848
query39	1474	1381	1386	1381
query40	275	120	116	116
query41	47	42	46	42
query42	122	93	99	93
query43	530	499	463	463
query44	1241	727	728	727
query45	204	168	164	164
query46	1130	741	748	741
query47	1829	1762	1775	1762
query48	373	295	292	292
query49	1091	432	446	432
query50	805	396	393	393
query51	6918	6757	6728	6728
query52	104	90	90	90
query53	261	189	190	189
query54	1063	456	449	449
query55	81	74	81	74
query56	292	267	262	262
query57	1162	1090	1051	1051
query58	249	247	229	229
query59	3099	2755	2748	2748
query60	315	269	274	269
query61	121	114	213	114
query62	798	613	634	613
query63	224	185	191	185
query64	6306	2274	1739	1739
query65	3296	3186	3194	3186
query66	1207	339	334	334
query67	15433	14950	14836	14836
query68	7837	563	564	563
query69	698	393	287	287
query70	1230	1051	1105	1051
query71	524	274	272	272
query72	7499	2257	1958	1958
query73	820	327	318	318
query74	9382	8755	8879	8755
query75	4886	2686	2691	2686
query76	4793	1013	987	987
query77	738	304	323	304
query78	9942	8947	10281	8947
query79	6900	538	536	536
query80	2036	492	483	483
query81	589	226	226	226
query82	530	141	134	134
query83	279	145	142	142
query84	263	78	73	73
query85	1390	307	268	268
query86	422	300	286	286
query87	4471	4185	4202	4185
query88	4140	2282	2283	2282
query89	414	288	282	282
query90	2077	195	188	188
query91	125	96	94	94
query92	68	53	49	49
query93	3601	536	535	535
query94	1056	297	284	284
query95	356	256	249	249
query96	609	267	266	266
query97	3212	3040	2992	2992
query98	230	199	198	198
query99	1595	1287	1250	1250
Total cold run time: 307678 ms
Total hot run time: 185112 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7f0eaf9e150108bbfe67959a4af1bee2dc02788, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.48	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.53	0.48	0.47
query10	0.53	0.53	0.54
query11	0.15	0.11	0.11
query12	0.14	0.12	0.13
query13	0.61	0.62	0.59
query14	0.78	0.77	0.79
query15	0.85	0.84	0.83
query16	0.37	0.38	0.37
query17	1.04	0.98	1.03
query18	0.23	0.22	0.22
query19	1.81	1.74	1.72
query20	0.01	0.01	0.01
query21	15.68	0.76	0.67
query22	4.83	6.47	2.25
query23	18.25	1.28	1.25
query24	2.05	0.22	0.23
query25	0.14	0.09	0.09
query26	0.29	0.23	0.22
query27	0.45	0.23	0.22
query28	13.27	1.03	1.01
query29	12.59	3.33	3.27
query30	0.25	0.06	0.05
query31	2.87	0.40	0.38
query32	3.28	0.49	0.49
query33	2.93	2.99	2.96
query34	16.83	4.35	4.40
query35	4.38	4.40	4.42
query36	0.66	0.46	0.46
query37	0.19	0.17	0.16
query38	0.16	0.16	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.13
query41	0.09	0.06	0.04
query42	0.05	0.04	0.05
query43	0.05	0.04	0.05
Total cold run time: 110.29 s
Total hot run time: 31.07 s

HappenLee
HappenLee approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Mryange
Copy link
Contributor Author

Mryange commented Aug 16, 2024

run cloud_p0

@BiteTheDDDDt BiteTheDDDDt merged commit caa9c3d into apache:master Aug 22, 2024
28 of 31 checks passed
Mryange added a commit to Mryange/doris that referenced this pull request Aug 27, 2024
@Mryange
[fix](function) fix error return type in mod(float32,BigInt) (apache#…
f60be1f 
…39358)

## Proposed changes

```
CREATE TABLE testdb (
    K1 BIGINT,
    K2 FLOAT
) properties("replication_num" = "1");
insert into testdb values(1,1.1);
select mod(k1,k2) from testdb;
mysql [test10]>select mod(k1,k2) from testdb;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Function mod get failed, expr is VectorizedFnCall[mod](arguments=K1, K2,return=Nullable(Float32)) and return type is Nullable(Float32).
```

<!--Describe your changes.-->
@Mryange Mryange mentioned this pull request Aug 27, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 27, 2024
@Mryange
[fix](function) fix error return type in mod(float32,BigInt) (#39358) (…
4127eec 
…#39971)

## Proposed changes
#39358
```
CREATE TABLE testdb (
    K1 BIGINT,
    K2 FLOAT
) properties("replication_num" = "1");
insert into testdb values(1,1.1);
select mod(k1,k2) from testdb;
mysql [test10]>select mod(k1,k2) from testdb;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Function mod get failed, expr is VectorizedFnCall[mod](arguments=K1, K2,return=Nullable(Float32)) and return type is Nullable(Float32).
```

<!--Describe your changes.-->

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@Mryange @dataroaring
[fix](function) fix error return type in mod(float32,BigInt) (#39358)
5cbfc0a 
## Proposed changes

```
CREATE TABLE testdb (
    K1 BIGINT,
    K2 FLOAT
) properties("replication_num" = "1");
insert into testdb values(1,1.1);
select mod(k1,k2) from testdb;
mysql [test10]>select mod(k1,k2) from testdb;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Function mod get failed, expr is VectorizedFnCall[mod](arguments=K1, K2,return=Nullable(Float32)) and return type is Nullable(Float32).
```

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.3-merged doing reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mryange @doris-robot @BiteTheDDDDt @HappenLee @yiguolei @dataroaring