-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](multi table) fix single stream multi table memory leak #38255
[fix](multi table) fix single stream multi table memory leak #38255
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39813 ms
|
TPC-DS: Total hot run time: 174015 ms
|
ClickBench: Total hot run time: 30.21 s
|
run buildall |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39629 ms
|
TPC-DS: Total hot run time: 173558 ms
|
ClickBench: Total hot run time: 30.79 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We meet OOM when using single stream multi table ![image](https://github.com/user-attachments/assets/748e9914-d591-4f41-8b28-412d3cecc841) It exist memory leak, and heap profile like: ![image](https://github.com/user-attachments/assets/af30c593-88ea-44f6-bba1-82436b13f99f) The stream load context will not release in some exception conditions as plan failed for high concurrency causing timeout when obtaining read lock. It is introduced by #35458 The solution effect is shown in the following figure, which can run stably with a small amount of memory ![image](https://github.com/user-attachments/assets/4483e0a5-6c0c-4cdc-b8ed-3408da6a86b2)
…#38824) pick (#38255) We meet OOM when using single stream multi table ![image](https://github.com/user-attachments/assets/748e9914-d591-4f41-8b28-412d3cecc841) It exist memory leak, and heap profile like: ![image](https://github.com/user-attachments/assets/af30c593-88ea-44f6-bba1-82436b13f99f) The stream load context will not release in some exception conditions as plan failed for high concurrency causing timeout when obtaining read lock. It is introduced by #35458 The solution effect is shown in the following figure, which can run stably with a small amount of memory ![image](https://github.com/user-attachments/assets/4483e0a5-6c0c-4cdc-b8ed-3408da6a86b2)
We meet OOM when using single stream multi table
It exist memory leak, and heap profile like:
The stream load context will not release in some exception conditions as plan failed for high concurrency causing timeout when obtaining read lock. It is introduced by #35458
The solution effect is shown in the following figure, which can run stably with a small amount of memory