-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]fix the crash of checksum task #3735 #3738
Conversation
1. the table include key colum of double/float type 2. when run checksum task, will use all of key columns to compare 3. schema.column(idx) of double/float type is NULL
This CL looks good to me. |
It's very confusing for me,doris does not support the key column as double or float,but I've met twice.
MySQL [search]> desc xxx_sku_AB; |
@marising |
I guess the table I think its ok to allow a float type column to be a sort column in DUPLICATE KEY table. @imay , is that right? |
@morningman I'm not sure about it either. However I think it is OK to make double/float column as a sort key. |
Aggregate Key, not Duplicate Key @morningman CREATE TABLE |
I can't reproduce this problem in the online cluster of customer, and the time for adding columns is a little long audit.log be cleaned up, I will pay attention to this problem |
ae0146a
to
75e85de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi @marising , if you finished this PR, please let me know, thank u. |
@morningman Ok,I'll tell you, if our internal review passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. the table include key column of double/float type 2. when run checksum task, will use all of key columns to compare 3. schema.column(idx) of double/float type is NULL apache#3735
#3735