Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](delete) fix the error message for valid decimal data #36802

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[fix](delete) fix the error message for valid decimal data #36802

merged 4 commits into from
Jul 12, 2024

Conversation

felixwluo
Copy link
Contributor

Proposed changes

Issue Number: close #36775

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@felixwluo
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40016 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88f660f1597603e629520de8938fbafb193a4fd0, data reload: false

------ Round 1 ----------------------------------
q1	17997	4538	4425	4425
q2	2357	196	186	186
q3	10465	1121	1076	1076
q4	10182	830	792	792
q5	7468	2669	2647	2647
q6	216	133	136	133
q7	951	612	596	596
q8	9224	2078	2091	2078
q9	8896	6506	6445	6445
q10	8772	3715	3775	3715
q11	444	243	232	232
q12	397	226	222	222
q13	17757	3007	3018	3007
q14	254	220	217	217
q15	515	505	489	489
q16	518	378	379	378
q17	969	626	695	626
q18	8057	7546	7497	7497
q19	7893	1473	1539	1473
q20	665	319	322	319
q21	4913	3271	3130	3130
q22	405	336	333	333
Total cold run time: 119315 ms
Total hot run time: 40016 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4365	4321	4267	4267
q2	358	276	254	254
q3	3003	2751	2775	2751
q4	1851	1627	1657	1627
q5	5253	5274	5274	5274
q6	215	128	130	128
q7	2137	1783	1719	1719
q8	3171	3342	3339	3339
q9	8389	8385	8341	8341
q10	3851	3700	3644	3644
q11	586	476	483	476
q12	762	637	587	587
q13	16379	3034	3017	3017
q14	279	275	249	249
q15	521	480	485	480
q16	463	415	419	415
q17	1775	1464	1465	1464
q18	7604	7622	7334	7334
q19	1676	1470	1467	1467
q20	1981	1776	1770	1770
q21	5035	4729	4630	4630
q22	624	573	569	569
Total cold run time: 70278 ms
Total hot run time: 53802 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 39598 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88f660f1597603e629520de8938fbafb193a4fd0, data reload: false

------ Round 1 ----------------------------------
q1	17634	4351	4248	4248
q2	2015	191	189	189
q3	10475	1102	1077	1077
q4	10191	856	739	739
q5	7467	2663	2630	2630
q6	230	138	147	138
q7	939	602	602	602
q8	9230	2041	2056	2041
q9	8726	6479	6442	6442
q10	8979	3691	3724	3691
q11	455	251	239	239
q12	494	231	227	227
q13	17748	3034	3046	3034
q14	275	236	226	226
q15	512	480	485	480
q16	512	377	377	377
q17	955	592	700	592
q18	7919	7290	7280	7280
q19	6200	1501	1522	1501
q20	642	313	322	313
q21	5084	3190	3872	3190
q22	401	342	365	342
Total cold run time: 117083 ms
Total hot run time: 39598 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4411	4229	4241	4229
q2	381	267	262	262
q3	2898	2851	2852	2851
q4	2005	1781	1680	1680
q5	5634	5507	5507	5507
q6	215	128	128	128
q7	2225	1879	1896	1879
q8	3220	3399	3442	3399
q9	8741	8634	8783	8634
q10	4088	3868	3770	3770
q11	598	498	498	498
q12	858	634	644	634
q13	16448	3181	3159	3159
q14	314	280	282	280
q15	531	511	486	486
q16	475	460	466	460
q17	1813	1534	1511	1511
q18	8005	7849	7732	7732
q19	1782	1565	1611	1565
q20	3101	1888	1877	1877
q21	5127	4902	4887	4887
q22	630	543	563	543
Total cold run time: 73500 ms
Total hot run time: 55971 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 88f660f1597603e629520de8938fbafb193a4fd0, data reload: false

query1	955	387	376	376
query2	6653	2520	2535	2520
query3	6628	207	222	207
query4	21035	17366	17165	17165
query5	3613	462	484	462
query6	243	169	166	166
query7	4585	300	298	298
query8	306	302	311	302
query9	8574	2410	2400	2400
query10	574	294	316	294
query11	11154	10109	10055	10055
query12	112	82	89	82
query13	1646	394	363	363
query14	10246	7615	7751	7615
query15	230	196	191	191
query16	7704	270	263	263
query17	1900	539	513	513
query18	1961	275	274	274
query19	198	151	158	151
query20	91	80	83	80
query21	209	135	124	124
query22	4305	3979	4034	3979
query23	33890	33447	33596	33447
query24	10985	2965	2947	2947
query25	587	383	376	376
query26	715	157	153	153
query27	2317	345	338	338
query28	5795	2162	2167	2162
query29	896	628	638	628
query30	234	152	162	152
query31	944	763	781	763
query32	93	58	57	57
query33	697	287	301	287
query34	942	485	491	485
query35	763	697	673	673
query36	1137	984	991	984
query37	148	71	74	71
query38	2948	2910	2825	2825
query39	908	839	849	839
query40	220	130	127	127
query41	54	53	54	53
query42	107	106	98	98
query43	607	598	551	551
query44	1162	745	729	729
query45	198	166	166	166
query46	1072	740	731	731
query47	1840	1759	1763	1759
query48	384	304	303	303
query49	847	415	431	415
query50	769	398	392	392
query51	6915	6859	6655	6655
query52	104	92	93	92
query53	370	295	296	295
query54	891	451	451	451
query55	79	73	74	73
query56	282	265	276	265
query57	1149	1066	1062	1062
query58	262	282	272	272
query59	3795	3185	3586	3185
query60	307	294	318	294
query61	94	94	94	94
query62	603	452	453	452
query63	323	292	285	285
query64	8531	2228	1764	1764
query65	3192	3092	3077	3077
query66	739	324	332	324
query67	15518	14822	14770	14770
query68	4518	556	587	556
query69	528	394	370	370
query70	1159	1158	1184	1158
query71	418	282	275	275
query72	7013	2758	2554	2554
query73	744	326	324	324
query74	5825	5546	5455	5455
query75	3410	2682	2727	2682
query76	2650	939	905	905
query77	489	321	320	320
query78	10466	9873	9720	9720
query79	2263	528	526	526
query80	1081	459	452	452
query81	599	221	225	221
query82	838	107	111	107
query83	241	173	172	172
query84	241	93	86	86
query85	1821	291	272	272
query86	494	298	317	298
query87	3279	3113	3048	3048
query88	4127	2384	2360	2360
query89	482	387	409	387
query90	1779	201	189	189
query91	128	100	100	100
query92	61	50	54	50
query93	2358	525	520	520
query94	1118	192	185	185
query95	409	317	316	316
query96	607	271	267	267
query97	3227	3060	3079	3060
query98	223	196	200	196
query99	1222	866	844	844
Total cold run time: 271153 ms
Total hot run time: 171776 ms

@jacktengg
Copy link
Contributor

The fix of BE is OK. But for illegal delete conditions, fe retries it until timeout, is this behaviour as expected?

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 88f660f1597603e629520de8938fbafb193a4fd0, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.67	0.10	0.09
query5	0.51	0.48	0.48
query6	1.15	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.48
query10	0.54	0.53	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.59
query14	0.76	0.79	0.80
query15	0.84	0.81	0.81
query16	0.37	0.36	0.35
query17	1.01	0.99	0.96
query18	0.22	0.24	0.25
query19	1.83	1.66	1.69
query20	0.02	0.01	0.01
query21	15.46	0.65	0.64
query22	4.41	7.28	1.66
query23	18.28	1.34	1.26
query24	2.10	0.24	0.22
query25	0.16	0.08	0.08
query26	0.27	0.17	0.18
query27	0.08	0.08	0.08
query28	13.22	1.03	1.02
query29	12.61	3.26	3.26
query30	0.25	0.06	0.07
query31	2.85	0.39	0.38
query32	3.27	0.49	0.47
query33	2.93	2.90	2.89
query34	17.17	4.45	4.46
query35	4.49	4.46	4.46
query36	0.64	0.48	0.46
query37	0.18	0.15	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.68 s
Total hot run time: 30.28 s

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 25, 2024
@felixwluo
Copy link
Contributor Author

run buildall

@felixwluo
Copy link
Contributor Author

The fix of BE is OK. But for illegal delete conditions, fe retries it until timeout, is this behaviour as expected?

Indeed, it has been modified

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40326 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c7cd3603520a36a4a943be3edee1abbb87f3dcf, data reload: false

------ Round 1 ----------------------------------
q1	17600	4352	4273	4273
q2	2009	180	178	178
q3	10492	1111	1091	1091
q4	10206	720	846	720
q5	7447	2666	2621	2621
q6	213	132	136	132
q7	941	602	601	601
q8	9215	2072	2058	2058
q9	9053	6530	6465	6465
q10	9007	3685	3737	3685
q11	486	231	231	231
q12	481	239	225	225
q13	17762	3018	3002	3002
q14	266	224	220	220
q15	515	490	463	463
q16	475	382	379	379
q17	965	717	705	705
q18	7875	7328	7434	7328
q19	2166	1447	1426	1426
q20	667	336	328	328
q21	5099	3850	3871	3850
q22	406	345	348	345
Total cold run time: 113346 ms
Total hot run time: 40326 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4390	4258	4275	4258
q2	386	267	252	252
q3	2990	2730	2763	2730
q4	1976	1681	1775	1681
q5	5547	5516	5519	5516
q6	219	131	130	130
q7	2247	1843	1871	1843
q8	3291	3449	3390	3390
q9	8682	8750	8773	8750
q10	4111	3930	3877	3877
q11	588	491	477	477
q12	789	669	638	638
q13	15859	3193	3155	3155
q14	307	279	266	266
q15	525	478	502	478
q16	486	420	434	420
q17	1831	1530	1472	1472
q18	8084	7984	7675	7675
q19	4571	1667	1719	1667
q20	2132	1864	1883	1864
q21	5227	5002	5016	5002
q22	614	544	541	541
Total cold run time: 74852 ms
Total hot run time: 56082 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174705 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c7cd3603520a36a4a943be3edee1abbb87f3dcf, data reload: false

query1	935	370	383	370
query2	6427	2470	2458	2458
query3	6636	211	204	204
query4	20833	17203	17088	17088
query5	3583	487	456	456
query6	249	155	158	155
query7	4589	289	290	289
query8	333	283	300	283
query9	8446	2405	2380	2380
query10	555	330	282	282
query11	10509	10063	9950	9950
query12	110	85	83	83
query13	1658	383	368	368
query14	10018	7857	7798	7798
query15	273	192	190	190
query16	7977	280	296	280
query17	1857	556	552	552
query18	2078	289	281	281
query19	210	156	162	156
query20	94	84	86	84
query21	214	128	131	128
query22	4496	4123	3895	3895
query23	33794	33667	33697	33667
query24	10797	2962	2879	2879
query25	600	408	402	402
query26	718	165	164	164
query27	2287	323	330	323
query28	5822	2160	2171	2160
query29	903	641	645	641
query30	266	158	158	158
query31	1001	780	755	755
query32	94	56	62	56
query33	686	305	303	303
query34	905	496	493	493
query35	783	678	639	639
query36	1154	1002	975	975
query37	151	77	74	74
query38	2942	2850	2819	2819
query39	907	827	842	827
query40	213	137	145	137
query41	59	54	57	54
query42	111	102	100	100
query43	611	559	556	556
query44	1225	743	748	743
query45	197	167	159	159
query46	1083	723	718	718
query47	1838	1786	1752	1752
query48	381	293	290	290
query49	838	404	426	404
query50	781	395	382	382
query51	6905	6844	6758	6758
query52	105	90	89	89
query53	364	293	286	286
query54	875	481	436	436
query55	74	74	73	73
query56	279	252	264	252
query57	1134	1055	1062	1055
query58	260	243	270	243
query59	3504	3349	3252	3252
query60	294	270	267	267
query61	107	90	88	88
query62	614	469	456	456
query63	316	292	290	290
query64	8500	2301	1736	1736
query65	3172	3097	3107	3097
query66	746	322	334	322
query67	15671	14902	15330	14902
query68	7070	561	562	561
query69	727	508	392	392
query70	1205	1043	1110	1043
query71	480	277	271	271
query72	8694	5410	5478	5410
query73	814	332	322	322
query74	5894	5557	5433	5433
query75	4599	2659	2662	2659
query76	4360	956	879	879
query77	774	295	307	295
query78	10359	10019	9839	9839
query79	7546	521	521	521
query80	1012	500	478	478
query81	573	230	222	222
query82	386	106	114	106
query83	350	179	172	172
query84	274	90	84	84
query85	925	286	277	277
query86	367	292	294	292
query87	3342	3105	3041	3041
query88	4828	2392	2375	2375
query89	484	381	373	373
query90	1947	196	188	188
query91	128	103	100	100
query92	66	50	52	50
query93	6283	530	515	515
query94	1318	189	186	186
query95	418	318	336	318
query96	625	270	267	267
query97	3272	3099	3025	3025
query98	216	203	194	194
query99	1149	855	866	855
Total cold run time: 286632 ms
Total hot run time: 174705 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c7cd3603520a36a4a943be3edee1abbb87f3dcf, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.21	0.05	0.05
query4	1.69	0.07	0.07
query5	0.52	0.48	0.48
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.51	0.51
query10	0.56	0.54	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.59	0.58	0.58
query14	0.75	0.81	0.79
query15	0.83	0.81	0.82
query16	0.36	0.35	0.36
query17	0.99	1.04	1.02
query18	0.22	0.24	0.22
query19	1.93	1.82	1.82
query20	0.01	0.01	0.01
query21	15.42	0.64	0.64
query22	3.59	7.58	2.09
query23	18.32	1.25	1.30
query24	2.07	0.23	0.22
query25	0.16	0.09	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.30	1.03	1.01
query29	12.67	3.31	3.34
query30	0.26	0.06	0.06
query31	2.86	0.40	0.38
query32	3.26	0.48	0.48
query33	2.89	2.92	2.93
query34	17.16	4.42	4.38
query35	4.49	4.52	4.51
query36	0.66	0.47	0.48
query37	0.19	0.15	0.16
query38	0.15	0.14	0.14
query39	0.05	0.03	0.03
query40	0.17	0.15	0.14
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.03 s
Total hot run time: 30.97 s

@jacktengg jacktengg requested a review from morrySnow June 25, 2024 14:59
@felixwluo
Copy link
Contributor Author

run p0

@felixwluo
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-DS: Total hot run time: 174086 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c82f3cb0850bf0dae9ad809108d9a17a0398174, data reload: false

query1	923	376	366	366
query2	6474	2308	2305	2305
query3	6631	204	217	204
query4	28270	17250	17577	17250
query5	3670	497	481	481
query6	258	173	161	161
query7	4594	297	299	297
query8	333	301	289	289
query9	8587	2385	2363	2363
query10	589	316	303	303
query11	10992	10041	10180	10041
query12	115	84	83	83
query13	1665	385	392	385
query14	10256	7773	7732	7732
query15	233	189	190	189
query16	7409	323	322	322
query17	1776	565	544	544
query18	1941	293	282	282
query19	204	159	160	159
query20	92	84	85	84
query21	225	133	133	133
query22	4391	4134	3969	3969
query23	34042	33855	33548	33548
query24	10659	2855	2840	2840
query25	606	425	406	406
query26	738	174	167	167
query27	2170	325	347	325
query28	6006	2182	2176	2176
query29	900	690	638	638
query30	270	155	160	155
query31	981	789	760	760
query32	98	60	58	58
query33	677	328	312	312
query34	891	516	498	498
query35	763	648	652	648
query36	1124	963	942	942
query37	138	85	83	83
query38	2957	2847	2810	2810
query39	907	864	800	800
query40	216	133	128	128
query41	55	53	51	51
query42	120	104	101	101
query43	590	537	556	537
query44	1094	749	761	749
query45	197	164	165	164
query46	1102	780	715	715
query47	1840	1771	1768	1768
query48	374	305	303	303
query49	951	417	433	417
query50	772	391	383	383
query51	6821	6851	6762	6762
query52	111	93	93	93
query53	354	289	283	283
query54	877	450	449	449
query55	72	73	76	73
query56	289	272	263	263
query57	1109	1033	1043	1033
query58	269	256	244	244
query59	3356	3250	3071	3071
query60	305	277	274	274
query61	118	99	96	96
query62	604	439	448	439
query63	310	292	292	292
query64	9141	2159	1629	1629
query65	3189	3111	3087	3087
query66	743	319	338	319
query67	15701	15019	14964	14964
query68	8242	568	561	561
query69	730	446	360	360
query70	1240	1157	1148	1148
query71	521	283	272	272
query72	8745	5470	5403	5403
query73	1134	326	331	326
query74	5941	5579	5497	5497
query75	5051	2636	2662	2636
query76	4662	989	873	873
query77	792	312	303	303
query78	9625	9073	10655	9073
query79	6985	515	510	510
query80	1079	488	478	478
query81	575	223	224	223
query82	557	107	108	107
query83	327	172	165	165
query84	276	90	95	90
query85	1302	309	308	308
query86	400	314	313	313
query87	3371	3132	3104	3104
query88	4259	2495	2473	2473
query89	499	386	378	378
query90	1954	196	192	192
query91	132	104	106	104
query92	60	49	50	49
query93	3409	520	517	517
query94	1234	208	208	208
query95	405	322	315	315
query96	601	271	276	271
query97	3166	2996	3047	2996
query98	223	205	198	198
query99	1160	840	854	840
Total cold run time: 292892 ms
Total hot run time: 174086 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c82f3cb0850bf0dae9ad809108d9a17a0398174, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.07
query5	0.49	0.48	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.50	0.50
query10	0.53	0.54	0.53
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.60	0.59
query14	0.78	0.79	0.76
query15	0.86	0.80	0.82
query16	0.37	0.37	0.38
query17	0.98	1.02	1.04
query18	0.22	0.23	0.26
query19	1.87	1.71	1.68
query20	0.01	0.01	0.01
query21	15.39	0.74	0.65
query22	3.93	6.76	2.52
query23	18.29	1.40	1.19
query24	2.11	0.23	0.23
query25	0.16	0.07	0.08
query26	0.29	0.20	0.20
query27	0.45	0.23	0.23
query28	13.30	1.02	1.00
query29	12.61	3.33	3.31
query30	0.25	0.06	0.06
query31	2.90	0.39	0.38
query32	3.25	0.49	0.47
query33	2.88	2.92	2.88
query34	16.96	4.33	4.36
query35	4.42	4.41	4.44
query36	0.65	0.47	0.50
query37	0.18	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.15	0.14	0.12
query41	0.10	0.06	0.06
query42	0.06	0.04	0.05
query43	0.05	0.03	0.04
Total cold run time: 109.36 s
Total hot run time: 31.15 s

@felixwluo felixwluo dismissed stale reviews from xy720 and cambyzju via 60c409c July 11, 2024 08:05
@felixwluo
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40232 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

------ Round 1 ----------------------------------
q1	17762	4614	4446	4446
q2	2363	192	189	189
q3	10480	1174	1099	1099
q4	10194	831	751	751
q5	7533	2738	2661	2661
q6	223	143	137	137
q7	973	605	598	598
q8	9219	2083	2121	2083
q9	8829	6564	6546	6546
q10	8762	3833	3764	3764
q11	452	244	246	244
q12	405	230	223	223
q13	17758	2976	2985	2976
q14	295	238	238	238
q15	560	488	488	488
q16	478	399	384	384
q17	987	698	671	671
q18	8148	7528	7467	7467
q19	8572	1543	1467	1467
q20	692	319	337	319
q21	4926	3147	3299	3147
q22	392	334	351	334
Total cold run time: 120003 ms
Total hot run time: 40232 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4471	4324	4260	4260
q2	366	270	264	264
q3	3031	2768	2752	2752
q4	1893	1626	1598	1598
q5	5320	5325	5303	5303
q6	222	130	129	129
q7	2165	1699	1647	1647
q8	3236	3357	3364	3357
q9	8484	8484	8464	8464
q10	3910	3654	3703	3654
q11	590	503	490	490
q12	821	612	632	612
q13	17536	2974	3024	2974
q14	298	275	276	275
q15	525	478	474	474
q16	475	404	419	404
q17	1790	1493	1456	1456
q18	7733	7574	7332	7332
q19	1730	1517	1677	1517
q20	2003	1792	1789	1789
q21	4963	4727	4678	4678
q22	609	572	524	524
Total cold run time: 72171 ms
Total hot run time: 53953 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174012 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

query1	913	382	366	366
query2	6452	2418	2283	2283
query3	6663	214	223	214
query4	21917	17426	17332	17332
query5	4179	492	498	492
query6	284	173	186	173
query7	4594	304	284	284
query8	319	303	306	303
query9	8521	2452	2431	2431
query10	432	280	271	271
query11	11240	10058	10096	10058
query12	133	80	84	80
query13	1631	362	360	360
query14	9443	7335	7542	7335
query15	233	185	192	185
query16	7817	315	313	313
query17	1759	543	521	521
query18	1959	280	277	277
query19	199	151	159	151
query20	91	84	83	83
query21	213	140	131	131
query22	4184	4158	4121	4121
query23	33678	33064	33376	33064
query24	12048	2911	2794	2794
query25	666	362	370	362
query26	1819	144	145	144
query27	3004	271	276	271
query28	7528	2094	2092	2092
query29	1182	639	604	604
query30	289	153	147	147
query31	987	742	736	736
query32	97	51	57	51
query33	764	298	293	293
query34	941	492	481	481
query35	683	558	550	550
query36	1118	932	918	918
query37	201	82	81	81
query38	2907	2739	2736	2736
query39	848	813	814	813
query40	277	119	122	119
query41	61	50	52	50
query42	116	98	102	98
query43	597	548	548	548
query44	1150	723	725	723
query45	192	171	166	166
query46	1086	706	725	706
query47	1885	1782	1769	1769
query48	378	291	294	291
query49	1182	404	435	404
query50	779	402	406	402
query51	6866	6799	6776	6776
query52	105	90	94	90
query53	360	321	286	286
query54	1011	445	440	440
query55	75	74	73	73
query56	289	269	262	262
query57	1138	1057	1077	1057
query58	255	254	249	249
query59	3348	3331	3240	3240
query60	332	274	283	274
query61	97	106	96	96
query62	812	634	667	634
query63	321	289	294	289
query64	10467	2205	1672	1672
query65	3170	3106	3099	3099
query66	1365	325	338	325
query67	15353	15023	14959	14959
query68	4618	539	533	533
query69	471	328	323	323
query70	1142	1128	1063	1063
query71	390	277	276	276
query72	6994	6389	5856	5856
query73	759	336	337	336
query74	5982	5552	5474	5474
query75	3412	2706	2706	2706
query76	2555	949	919	919
query77	460	307	299	299
query78	10447	8938	9079	8938
query79	2728	522	517	517
query80	2051	466	468	466
query81	574	217	221	217
query82	760	134	134	134
query83	279	172	171	171
query84	275	88	90	88
query85	2103	305	307	305
query86	485	308	332	308
query87	3268	3136	3120	3120
query88	4190	2453	2441	2441
query89	459	380	380	380
query90	1840	192	187	187
query91	133	103	106	103
query92	63	50	52	50
query93	2598	513	510	510
query94	1276	215	269	215
query95	403	315	323	315
query96	604	275	271	271
query97	3166	3037	3048	3037
query98	225	201	200	200
query99	1793	1256	1259	1256
Total cold run time: 281506 ms
Total hot run time: 174012 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.06	0.07
query5	0.50	0.48	0.49
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.49
query10	0.54	0.53	0.54
query11	0.15	0.11	0.12
query12	0.14	0.12	0.13
query13	0.60	0.58	0.59
query14	0.77	0.78	0.76
query15	0.85	0.82	0.80
query16	0.37	0.38	0.37
query17	0.93	0.97	1.04
query18	0.23	0.22	0.22
query19	1.88	1.82	1.86
query20	0.03	0.01	0.02
query21	15.40	0.77	0.65
query22	4.07	6.69	2.17
query23	18.30	1.35	1.21
query24	2.10	0.22	0.22
query25	0.16	0.08	0.10
query26	0.31	0.21	0.21
query27	0.46	0.23	0.25
query28	13.30	1.01	1.02
query29	12.57	3.35	3.29
query30	0.26	0.06	0.05
query31	2.91	0.41	0.39
query32	3.22	0.48	0.46
query33	2.94	2.90	2.94
query34	17.28	4.36	4.36
query35	4.44	4.42	4.40
query36	0.65	0.47	0.51
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.14	0.11	0.13
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.86 s
Total hot run time: 30.91 s

yiguolei
yiguolei approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixwluo
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40088 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

------ Round 1 ----------------------------------
q1	18045	4391	4357	4357
q2	2933	198	191	191
q3	10956	1185	1148	1148
q4	10762	795	831	795
q5	7674	2719	2633	2633
q6	224	140	138	138
q7	946	607	605	605
q8	9334	2056	2073	2056
q9	8597	6614	6571	6571
q10	8667	3746	3785	3746
q11	457	243	243	243
q12	394	231	226	226
q13	17758	2944	2960	2944
q14	280	244	234	234
q15	518	485	465	465
q16	450	379	377	377
q17	957	755	745	745
q18	7986	7567	7399	7399
q19	5703	1433	1513	1433
q20	694	330	329	329
q21	4851	3121	3224	3121
q22	391	338	332	332
Total cold run time: 118577 ms
Total hot run time: 40088 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4336	4203	4297	4203
q2	364	267	262	262
q3	3021	2731	2693	2693
q4	1847	1633	1625	1625
q5	5290	5344	5282	5282
q6	215	133	131	131
q7	2114	1757	1756	1756
q8	3204	3306	3279	3279
q9	8419	8439	8383	8383
q10	3870	3637	3638	3637
q11	574	497	505	497
q12	778	582	593	582
q13	16333	2981	2983	2981
q14	298	277	272	272
q15	514	478	478	478
q16	472	423	418	418
q17	1743	1501	1474	1474
q18	7564	7699	7336	7336
q19	2901	1668	1486	1486
q20	2011	1769	1768	1768
q21	4865	4634	4775	4634
q22	648	543	555	543
Total cold run time: 71381 ms
Total hot run time: 53720 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174849 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

query1	917	378	363	363
query2	6470	2436	2385	2385
query3	6670	212	224	212
query4	23975	17426	17461	17426
query5	4211	464	477	464
query6	271	193	153	153
query7	4587	292	291	291
query8	331	322	297	297
query9	8516	2459	2433	2433
query10	448	282	287	282
query11	11710	10175	10126	10126
query12	134	87	89	87
query13	1663	382	376	376
query14	10315	7672	7629	7629
query15	247	192	194	192
query16	7836	346	333	333
query17	1757	554	564	554
query18	2011	293	286	286
query19	204	160	159	159
query20	93	82	87	82
query21	208	134	129	129
query22	4357	4192	4306	4192
query23	33568	33008	33074	33008
query24	11935	2902	2840	2840
query25	686	391	392	391
query26	1737	155	157	155
query27	2875	279	274	274
query28	7683	2091	2080	2080
query29	1056	654	639	639
query30	284	152	151	151
query31	950	743	748	743
query32	98	57	57	57
query33	795	335	307	307
query34	905	516	506	506
query35	708	588	567	567
query36	1090	935	925	925
query37	144	86	83	83
query38	2896	2739	2781	2739
query39	861	824	798	798
query40	277	126	123	123
query41	60	53	56	53
query42	126	99	104	99
query43	594	570	535	535
query44	1233	742	723	723
query45	194	162	173	162
query46	1096	762	740	740
query47	1890	1772	1794	1772
query48	373	311	302	302
query49	1163	439	424	424
query50	793	406	408	406
query51	7005	6790	6792	6790
query52	109	95	104	95
query53	369	298	290	290
query54	968	457	455	455
query55	79	75	75	75
query56	305	288	306	288
query57	1151	1048	1079	1048
query58	272	248	258	248
query59	3531	3156	3166	3156
query60	341	283	282	282
query61	98	97	101	97
query62	811	649	652	649
query63	324	289	290	289
query64	10485	2247	1687	1687
query65	3219	3127	3093	3093
query66	1408	363	345	345
query67	15689	15164	15254	15164
query68	8739	558	545	545
query69	755	488	351	351
query70	1388	1113	1129	1113
query71	526	276	277	276
query72	8418	5425	5665	5425
query73	2258	333	333	333
query74	5959	5571	5438	5438
query75	5105	2696	2679	2679
query76	5375	1007	985	985
query77	756	298	353	298
query78	9628	9096	8980	8980
query79	7975	536	531	531
query80	2188	476	483	476
query81	588	221	227	221
query82	673	140	137	137
query83	290	166	167	166
query84	276	85	90	85
query85	1064	334	336	334
query86	362	313	294	294
query87	3354	3144	3137	3137
query88	4738	2463	2484	2463
query89	538	377	379	377
query90	2042	198	198	198
query91	134	105	104	104
query92	67	52	47	47
query93	6061	507	510	507
query94	1373	220	216	216
query95	419	325	325	325
query96	602	276	270	270
query97	3171	3025	3058	3025
query98	212	196	197	196
query99	1586	1289	1213	1213
Total cold run time: 305785 ms
Total hot run time: 174849 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 382d35b2f3a8c896116ad3622f3db19f4d749303, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.49	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.48
query10	0.55	0.54	0.53
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	0.76	0.78	0.78
query15	0.86	0.81	0.82
query16	0.37	0.37	0.37
query17	1.05	0.97	1.04
query18	0.23	0.22	0.23
query19	1.87	1.85	1.74
query20	0.01	0.00	0.01
query21	15.39	0.74	0.67
query22	4.60	5.54	2.46
query23	18.30	1.35	1.27
query24	2.16	0.23	0.23
query25	0.15	0.08	0.09
query26	0.30	0.21	0.20
query27	0.45	0.23	0.23
query28	13.25	1.00	1.01
query29	12.59	3.33	3.31
query30	0.26	0.06	0.06
query31	2.88	0.39	0.39
query32	3.26	0.49	0.48
query33	2.90	2.90	2.91
query34	17.00	4.36	4.37
query35	4.41	4.38	4.38
query36	0.65	0.49	0.49
query37	0.18	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.15 s
Total hot run time: 31.28 s

@yiguolei yiguolei merged commit 37ed7ad into apache:master Jul 12, 2024
25 of 29 checks passed
@felixwluo felixwluo mentioned this pull request Jul 12, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 15, 2024
@felixwluo
[fix](delete) fix the error message for valid decimal data for 2.1 (#…
b55dd6f 
…37710)

## Proposed changes

cherry-pick : #36802

<!--Describe your changes.-->
@felixwluo felixwluo mentioned this pull request Jul 15, 2024
Closed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@felixwluo @seawinde
[fix](delete) fix the error message for valid decimal data (apache#36802
b21c569 
)

## Proposed changes

Issue Number: close apache#36775

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@felixwluo @dataroaring
[fix](delete) fix the error message for valid decimal data (#36802)
8d8e65a 
## Proposed changes

Issue Number: close #36775

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cambyzju cambyzju cambyzju approved these changes

@yiguolei yiguolei yiguolei approved these changes

@xy720 xy720 xy720 left review comments

@morrySnow morrySnow Awaiting requested review from morrySnow

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] delete from table where key=xxx hangs
7 participants
@felixwluo @doris-robot @jacktengg @dataroaring @yiguolei @cambyzju @xy720